From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 186FD42528; Wed, 6 Sep 2023 11:13:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0D1E402AE; Wed, 6 Sep 2023 11:13:36 +0200 (CEST) Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) by mails.dpdk.org (Postfix) with ESMTP id 019584029E for ; Wed, 6 Sep 2023 11:13:34 +0200 (CEST) X-QQ-mid: bizesmtp86t1693991603t2uoooyv Received: from LAPTOP96V0OHHN ( [183.81.182.182]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 06 Sep 2023 17:13:22 +0800 (CST) X-QQ-SSF: 00400000000000D0F000000A0000000 X-QQ-FEAT: J14clyG+6H7lZ8mTbvphaqImTcFnz7EJbnnbWllwA2WE3FUrLIqV3/wZk9oA6 6i8LqCYRWYgdFrHMrrmBvLoPGSuX397HRXjZO9+grJpBBSg5Z5lu28g3u+kX/UBF5PkWMj5 dh7s+nHM78dz0DyPwO+M2XAObgo7kAFRUiArSfvMFAJVgfZIzvFhUhx831V5jHHfIIEPap0 f8uNN3OGdt2bCAAfgN90ltTY7NjlW+7BsBVe0OLFE41R0l7k/6vR/2zqMmiwncuDw7oF2ps z90P0F8CNt/azljxYfREql6pAfcv2tShw8uL6KWQ24h04w3mkEk/6TzhIMtfL66wm3HxoiW S4oBvAX0pyd7ir5wXjMH62k2XkIyUqsdkMatROIuYIw5AsUFhQBysMh0HB+0yZIz0YEtzrx EjdMa6S1z5w= X-QQ-GoodBg: 2 X-BIZMAIL-ID: 11424598748861848068 From: "11" To: "'Ferruh Yigit'" Cc: , , , References: <20230901023050.40893-1-caowenbo@mucse.com> <20230901023050.40893-8-caowenbo@mucse.com> <2fd454a8-fa2e-0acd-7f37-37bf87be7f5b@amd.com> In-Reply-To: <2fd454a8-fa2e-0acd-7f37-37bf87be7f5b@amd.com> Subject: RE: [PATCH v6 7/8] net/rnp add devargs runtime parsing functions Date: Wed, 6 Sep 2023 17:13:23 +0800 Message-ID: <02178876FA3C6F2B+00a801d9e0a2$63eb5070$2bc1f150$@mucse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: zh-cn Thread-Index: AQI30P9XUj3aWZJ7n+uYhLh06w3v0AIJ4HbvAkznZaCvLutH4A== X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:mucse.com:qybglogicsvrgz:qybglogicsvrgz5a-0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ferruh Yigit > Sent: 2023=E5=B9=B49=E6=9C=885=E6=97=A5 23:47 > To: Wenbo Cao > Cc: dev@dpdk.org; thomas@monjalon.net; andrew.rybchenko@oktetlabs.ru; > yaojun@mucse.com > Subject: Re: [PATCH v6 7/8] net/rnp add devargs runtime parsing = functions >=20 > On 9/1/2023 3:30 AM, Wenbo Cao wrote: > > add various runtime devargs command line options supported by this > > driver. > > > > Signed-off-by: Wenbo Cao >=20 > <...> >=20 > > > > +#define RNP_HW_MAC_LOOPBACK_ARG "hw_loopback" > > +#define RNP_FW_UPDATE "fw_update" > > +#define RNP_RX_FUNC_SELECT "rx_func_sec" > > +#define RNP_TX_FUNC_SELECT "tx_func_sec" > > +#define RNP_FW_4X10G_10G_1G_DET "fw_4x10g_10g_1g_auto_det" > > +#define RNP_FW_FORCE_SPEED_1G "fw_force_1g_speed" > > + >=20 > Please document these runtime arguments in the device document. >=20 > Also please add 'RTE_PMD_REGISTER_PARAM_STRING()' macros to document > argument for pmdinfogen, please see samples in existing code. >=20 > <...> >=20 OK, I will check the samples. > > + > > +static int > > +rnp_parse_io_select_func(const char *key, const char *value, void > > +*extra_args) { > > + uint8_t select =3D RNP_IO_FUNC_USE_NONE; > > + > > + RTE_SET_USED(key); > > + > > + if (strcmp(value, "vec") =3D=3D 0) > > + select =3D RNP_IO_FUNC_USE_VEC; > > + else if (strcmp(value, "simple") =3D=3D 0) > > + select =3D RNP_IO_FUNC_USE_SIMPLE; > > + else if (strcmp(value, "common") =3D=3D 0) > > + select =3D RNP_IO_FUNC_USE_COMMON; > > + >=20 > There is already an generic eal argument that lets you select between = vector and > scalar datapath implementation: > --force-max-simd-bitwidth=3D >=20 > <...> >=20 > --force-max-simd-bitwidth=3D This option I have noticed before. Thanks a lot. I will check the generic eal argume code, and reedit the interrelated = code > > +static int rnp_post_handle(struct rnp_eth_adapter *adapter) { > > + bool on =3D false; > > + > > + if (!adapter->eth_dev) > > + return -ENOMEM; > > + if (adapter->do_fw_update && adapter->fw_path) { > > + rnp_fw_update(adapter); > > + adapter->do_fw_update =3D 0; >=20 > This patch also enables FW upgrade, can you please detail this in the = commit log? > Or even you can consider to split this part into separate patch. >=20 >=20 >=20 For this, I will split it to another commit.