From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 20D381B39C; Mon, 15 Apr 2019 18:40:50 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 58F5F86678; Mon, 15 Apr 2019 16:40:49 +0000 (UTC) Received: from [10.36.117.138] (ovpn-117-138.ams2.redhat.com [10.36.117.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id 490601001DE8; Mon, 15 Apr 2019 16:40:48 +0000 (UTC) To: David Christensen , david.hunt@intel.com Cc: dev@dpdk.org, stable@dpdk.org References: <1554228857-55396-1-git-send-email-drc@linux.vnet.ibm.com> From: Kevin Traynor Message-ID: <021bab1b-9f3b-c301-acbd-98eb642a12b3@redhat.com> Date: Mon, 15 Apr 2019 17:40:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1554228857-55396-1-git-send-email-drc@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 15 Apr 2019 16:40:49 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] examples/vm_power: add conditional compilation for PMD specific code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Apr 2019 16:40:50 -0000 On 02/04/2019 19:14, David Christensen wrote: I think it should have Fixes: and probably stable tags. > Signed-off-by: David Christensen > --- > Running the devtools/test-build.sh script on IBM Power systems fails > because the IXGBE_PMD is explicity disabled for Power as an untested > driver, but the examples/vm_power_manager application has a hard > dependency on a function call in the IXGBE_PMD. > > Modify the example application so that all dependencies on PMD code > are conditionally compiled. > > examples/vm_power_manager/main.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8037DA00E6 for ; Mon, 15 Apr 2019 18:40:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E825A1B39D; Mon, 15 Apr 2019 18:40:51 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 20D381B39C; Mon, 15 Apr 2019 18:40:50 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 58F5F86678; Mon, 15 Apr 2019 16:40:49 +0000 (UTC) Received: from [10.36.117.138] (ovpn-117-138.ams2.redhat.com [10.36.117.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id 490601001DE8; Mon, 15 Apr 2019 16:40:48 +0000 (UTC) To: David Christensen , david.hunt@intel.com Cc: dev@dpdk.org, stable@dpdk.org References: <1554228857-55396-1-git-send-email-drc@linux.vnet.ibm.com> From: Kevin Traynor Message-ID: <021bab1b-9f3b-c301-acbd-98eb642a12b3@redhat.com> Date: Mon, 15 Apr 2019 17:40:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1554228857-55396-1-git-send-email-drc@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 15 Apr 2019 16:40:49 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] examples/vm_power: add conditional compilation for PMD specific code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190415164047.VhFgDHFbUxy5Ciy0HYZtP83OR4nEnfggsH9Fq9H0CS8@z> On 02/04/2019 19:14, David Christensen wrote: I think it should have Fixes: and probably stable tags. > Signed-off-by: David Christensen > --- > Running the devtools/test-build.sh script on IBM Power systems fails > because the IXGBE_PMD is explicity disabled for Power as an untested > driver, but the examples/vm_power_manager application has a hard > dependency on a function call in the IXGBE_PMD. > > Modify the example application so that all dependencies on PMD code > are conditionally compiled. > > examples/vm_power_manager/main.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+)