From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11E8C455F3; Sat, 13 Jul 2024 04:16:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EA0040655; Sat, 13 Jul 2024 04:16:52 +0200 (CEST) Received: from smtpbgsg1.qq.com (smtpbgsg1.qq.com [54.254.200.92]) by mails.dpdk.org (Postfix) with ESMTP id F1803402C6 for ; Sat, 13 Jul 2024 04:16:50 +0200 (CEST) X-QQ-mid: Yeas8t1720836986t628t24715 Received: from 3DB253DBDE8942B29385B9DFB0B7E889 (jiawenwu@trustnetic.com [125.119.243.105]) X-QQ-SSF: 00400000000000F0FVF000000000000 From: =?utf-8?b?Smlhd2VuIFd1?= X-BIZMAIL-ID: 16385367850636191587 To: "'Ferruh Yigit'" , "'David Marchand'" , "'Thomas Monjalon'" Cc: , "'Bruce Richardson'" References: <20240618071150.21564-1-jiawenwu@trustnetic.com> <036a01dac6a2$32a29b90$97e7d2b0$@trustnetic.com> <08e601daceb3$02b846f0$0828d4d0$@trustnetic.com> <86c28a61-d277-4dfe-83ce-cf146563241a@amd.com> <2196a63c-9f94-46c2-bb8a-7a8c8a420a95@amd.com> In-Reply-To: <2196a63c-9f94-46c2-bb8a-7a8c8a420a95@amd.com> Subject: RE: [PATCH 00/19] Wangxun fixes and supports Date: Sat, 13 Jul 2024 10:16:25 +0800 Message-ID: <021d01dad4ca$a9aa6610$fcff3230$@trustnetic.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: zh-cn Thread-Index: AQHT4561YHDS+Zm68TKz6m0rT0fSVgDetdFlAgttwUABWyZv4wIwE5vaAjl2WVcCd6BYZgIbQlGksZe9hOA= X-QQ-SENDSIZE: 520 Feedback-ID: Yeas:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jul 12, 2024 11:31 PM, Ferruh Yigit wrote: > On 7/12/2024 1:47 PM, Ferruh Yigit wrote: > > On 7/12/2024 10:32 AM, David Marchand wrote: > >> On Thu, Jul 11, 2024 at 1:53=E2=80=AFPM David Marchand > >> wrote: > >>> On Sat, Jul 6, 2024 at 5:39=E2=80=AFAM Ferruh Yigit = wrote: > >>>>>>> Fix some bugs in txgbe/ngbe, and support new features in ngbe = driver. > >>>>>>> > >>>>>>> Jiawen Wu (19): > >>>>>>> net/txgbe: fix to parse tunnel packets > >>>>>>> net/txgbe: fix flow filters in VT mode > >>>>>>> net/txgbe: fix Tx hang on queue disable > >>>>>>> net/txgbe: restrict the configuration of VLAN strip offload > >>>>>>> net/txgbe: reconfigure more MAC Rx registers > >>>>>>> net/txgbe: fix VF promiscuous and allmulticast > >>>>>>> net/ngbe: special config for YT8531SH-CA PHY > >>>>>>> net/ngbe: keep PHY power down while device probing > >>>>>>> net/ngbe: add WOL and NCSI capability > >>>>>>> net/txgbe: fix hotplug remove > >>>>>>> net/ngbe: fix hotplug remove > >>>>>>> net/txgbe: correct valid MTU range > >>>>>>> net/ngbe: correct valid MTU range > >>>>>>> net/txgbe: fix memory leak > >>>>>>> net/ngbe: fix memory leak > >>>>>>> net/txgbe: fix Rx interrupt > >>>>>>> net/ngbe: support Rx interrupt > >>>>>>> net/txgbe: disable LLDP by default > >>>>>>> net/ngbe: disable LLDP by default > >>>>>> > >>>>> > >>>> > >>>> Series applied to dpdk-next-net/main, thanks. > >>> > >>> Compilation is broken for some ARM targets with next-net. > >>> It was detected by the CI: > >>> http://mails.dpdk.org/archives/test-report/2024-June/700549.html > >>> > >>> Jiawen, please send a fix. > >> > >> Ferruh, Thomas, > >> > >> We have many build failure reports because of this series. > >> What is the best approach while waiting for a fix? > >> Can we drop patch 35c4da655a95 ("net/ngbe: disable LLDP by = default") > >> (which seems to be the cause) from next-net? > >> > > > > Hi David, > > > > I can check if the error is trivial, and if so send a patch for it. > > >=20 > Error is: > In function 'ngbe_host_interface_command', > inlined from 'ngbe_host_interface_command' at > ../drivers/net/ngbe/base/ngbe_mng.c:86:1, > inlined from 'ngbe_hic_get_lldp' at > ../drivers/net/ngbe/base/ngbe_mng.c:394:8: > ../drivers/net/ngbe/base/ngbe_mng.c:127:36: error: array subscript 2 = is > outside array bounds of 'struct ngbe_hic_write_lldp[1]' > [-Werror=3Darray-bounds] > 127 | buffer[bi] =3D rd32a(hw, NGBE_MNGMBX, = bi); > ../drivers/net/ngbe/base/ngbe_mng.c: In function 'ngbe_hic_get_lldp': > ../drivers/net/ngbe/base/ngbe_mng.c:385:36: note: at offset 8 into > object 'buffer' of size 8 > 385 | struct ngbe_hic_write_lldp buffer; > | ^~~~~~ >=20 >=20 > Problematic case only happens when 'resp->cmd =3D=3D 0x30', but for > 'get_lldp', cmd is 'FW_LLDP_GET_CMD' which is 0xF5, so practically = this > is not a real issue. >=20 > To build the build log, we have options: > 1. Extend "struct ngbe_hic_read_pcie" with 'u32 pad4' > 2. Remove 'resp->cmd =3D=3D 0x30' exception in > 'ngbe_host_interface_command()' as that command seems not supported at = all. >=20 > But I can't be sure on possible side impacts of above changes. >=20 > Another option is dropping this patch from the next-net and a fixed > version can be merged back. Sorry for these build error, I don't have a platform to verify this yet. But I think the fix should be extending 'struct ngbe_hic_write_lldp'.