From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id BD7265F32 for ; Wed, 10 Apr 2019 13:28:38 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from dekelp@mellanox.com) with ESMTPS (AES256-SHA encrypted); 10 Apr 2019 14:28:37 +0300 Received: from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx [10.128.130.87]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x3ABSUlD011408; Wed, 10 Apr 2019 14:28:36 +0300 From: Dekel Peled To: adrien.mazarguil@6wind.com, wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, yskoh@mellanox.com, shahafs@mellanox.com, arybchenko@solarflare.com Cc: dev@dpdk.org, orika@mellanox.com, dekelp@mellanox.com Date: Wed, 10 Apr 2019 14:26:38 +0300 Message-Id: <0235680ea84ba74d3ecebb62bf5af19559c5170e.1554894982.git.dekelp@mellanox.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: References: <1554218001-62012-1-git-send-email-dekelp@mellanox.com> Subject: [dpdk-dev] [PATCH v3 1/3] ethdev: add actions to modify TCP header fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2019 11:28:39 -0000 Add actions: - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP header. - DEC_TCP_ACK - Decrease acknowledgment number in the outermost TCP header. Original work by Xiaoyu Min. Signed-off-by: Dekel Peled --- doc/guides/prog_guide/rte_flow.rst | 72 ++++++++++++++++++++++++++++++++++++++ lib/librte_ethdev/rte_flow.c | 4 +++ lib/librte_ethdev/rte_flow.h | 60 +++++++++++++++++++++++++++++++ 3 files changed, 136 insertions(+) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 0203f4f..58cf6cc 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -2345,6 +2345,78 @@ Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. | ``mac_addr`` | MAC address | +--------------+---------------+ +Action: ``INC_TCP_SEQ`` +^^^^^^^^^^^^^^^^^^^^^^^ + +Increase sequence number in the outermost TCP header. + +Using this action on non-matching traffic will result in undefined behavior, +depending on PMD implementation. + +.. _table_rte_flow_action_inc_tcp_seq: + +.. table:: INC_TCP_SEQ + + +-----------+------------------------------------------+ + | Field | Value | + +===========+==========================================+ + | ``value`` | Value to increase TCP sequence number by | + +-----------+------------------------------------------+ + +Action: ``DEC_TCP_SEQ`` +^^^^^^^^^^^^^^^^^^^^^^^ + +Decrease sequence number in the outermost TCP header. + +Using this action on non-matching traffic will result in undefined behavior, +depending on PMD implementation. + +.. _table_rte_flow_action_dec_tcp_seq: + +.. table:: DEC_TCP_SEQ + + +-----------+------------------------------------------+ + | Field | Value | + +===========+==========================================+ + | ``value`` | Value to decrease TCP sequence number by | + +-----------+------------------------------------------+ + +Action: ``INC_TCP_ACK`` +^^^^^^^^^^^^^^^^^^^^^^^ + +Increase acknowledgment number in the outermost TCP header. + +Using this action on non-matching traffic will result in undefined behavior, +depending on PMD implementation. + +.. _table_rte_flow_action_inc_tcp_ack: + +.. table:: INC_TCP_ACK + + +-----------+------------------------------------------------+ + | Field | Value | + +===========+================================================+ + | ``value`` | Value to increase TCP acknowledgment number by | + +-----------+------------------------------------------------+ + +Action: ``DEC_TCP_ACK`` +^^^^^^^^^^^^^^^^^^^^^^^ + +Decrease acknowledgment number in the outermost TCP header. + +Using this action on non-matching traffic will result in undefined behavior, +depending on PMD implementation. + +.. _table_rte_flow_action_dec_tcp_ack: + +.. table:: DEC_TCP_ACK + + +-----------+------------------------------------------------+ + | Field | Value | + +===========+================================================+ + | ``value`` | Value to decrease TCP acknowledgment number by | + +-----------+------------------------------------------------+ + Negative types ~~~~~~~~~~~~~~ diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c index 3277be1..ed4e643 100644 --- a/lib/librte_ethdev/rte_flow.c +++ b/lib/librte_ethdev/rte_flow.c @@ -143,6 +143,10 @@ struct rte_flow_desc_data { MK_FLOW_ACTION(SET_TTL, sizeof(struct rte_flow_action_set_ttl)), MK_FLOW_ACTION(SET_MAC_SRC, sizeof(struct rte_flow_action_set_mac)), MK_FLOW_ACTION(SET_MAC_DST, sizeof(struct rte_flow_action_set_mac)), + MK_FLOW_ACTION(INC_TCP_SEQ, sizeof(struct rte_flow_general_action)), + MK_FLOW_ACTION(DEC_TCP_SEQ, sizeof(struct rte_flow_general_action)), + MK_FLOW_ACTION(INC_TCP_ACK, sizeof(struct rte_flow_general_action)), + MK_FLOW_ACTION(DEC_TCP_ACK, sizeof(struct rte_flow_general_action)), }; static int diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index c0fe879..3b0e262 100644 --- a/lib/librte_ethdev/rte_flow.h +++ b/lib/librte_ethdev/rte_flow.h @@ -1651,6 +1651,46 @@ enum rte_flow_action_type { * See struct rte_flow_action_set_mac. */ RTE_FLOW_ACTION_TYPE_SET_MAC_DST, + + /** + * Increase sequence number in the outermost TCP header. + * + * Using this action on non-matching traffic will result in + * undefined behavior, depending on PMD implementation. + * + * See struct rte_flow_general_action. + */ + RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ, + + /** + * Decrease sequence number in the outermost TCP header. + * + * Using this action on non-matching traffic will result in + * undefined behavior, depending on PMD implementation. + * + * See struct rte_flow_general_action. + */ + RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ, + + /** + * Increase acknowledgment number in the outermost TCP header. + * + * Using this action on non-matching traffic will result in + * undefined behavior, depending on PMD implementation. + * + * See struct rte_flow_general_action. + */ + RTE_FLOW_ACTION_TYPE_INC_TCP_ACK, + + /** + * Decrease acknowledgment number in the outermost TCP header. + * + * Using this action on non-matching traffic will result in + * undefined behavior, depending on PMD implementation. + * + * See struct rte_flow_general_action. + */ + RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK, }; /** @@ -2123,6 +2163,26 @@ struct rte_flow_action_set_mac { }; /* + * @warning + * @b EXPERIMENTAL: this union may change without prior notice + * + * General integer type, can be expanded as needed. +*/ +union rte_flow_integer { + rte_be32_t be32; +}; + +/** + * @warning + * @b EXPERIMENTAL: this structure may change without prior notice + * + * General struct, for use by actions that require a single integer value. + */ +struct rte_flow_general_action { + union rte_flow_integer integer; +}; + +/* * Definition of a single action. * * A list of actions is terminated by a END action. -- 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3FA14A0096 for ; Wed, 10 Apr 2019 13:28:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D8F7F6833; Wed, 10 Apr 2019 13:28:44 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id BD7265F32 for ; Wed, 10 Apr 2019 13:28:38 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from dekelp@mellanox.com) with ESMTPS (AES256-SHA encrypted); 10 Apr 2019 14:28:37 +0300 Received: from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx [10.128.130.87]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x3ABSUlD011408; Wed, 10 Apr 2019 14:28:36 +0300 From: Dekel Peled To: adrien.mazarguil@6wind.com, wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, yskoh@mellanox.com, shahafs@mellanox.com, arybchenko@solarflare.com Cc: dev@dpdk.org, orika@mellanox.com, dekelp@mellanox.com Date: Wed, 10 Apr 2019 14:26:38 +0300 Message-Id: <0235680ea84ba74d3ecebb62bf5af19559c5170e.1554894982.git.dekelp@mellanox.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: References: <1554218001-62012-1-git-send-email-dekelp@mellanox.com> Subject: [dpdk-dev] [PATCH v3 1/3] ethdev: add actions to modify TCP header fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190410112638.ER4ZO59fGDdwefpPdIm_mv1vS9XrZZGIZnGoLV58du4@z> Add actions: - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP header. - DEC_TCP_ACK - Decrease acknowledgment number in the outermost TCP header. Original work by Xiaoyu Min. Signed-off-by: Dekel Peled --- doc/guides/prog_guide/rte_flow.rst | 72 ++++++++++++++++++++++++++++++++++++++ lib/librte_ethdev/rte_flow.c | 4 +++ lib/librte_ethdev/rte_flow.h | 60 +++++++++++++++++++++++++++++++ 3 files changed, 136 insertions(+) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 0203f4f..58cf6cc 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -2345,6 +2345,78 @@ Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. | ``mac_addr`` | MAC address | +--------------+---------------+ +Action: ``INC_TCP_SEQ`` +^^^^^^^^^^^^^^^^^^^^^^^ + +Increase sequence number in the outermost TCP header. + +Using this action on non-matching traffic will result in undefined behavior, +depending on PMD implementation. + +.. _table_rte_flow_action_inc_tcp_seq: + +.. table:: INC_TCP_SEQ + + +-----------+------------------------------------------+ + | Field | Value | + +===========+==========================================+ + | ``value`` | Value to increase TCP sequence number by | + +-----------+------------------------------------------+ + +Action: ``DEC_TCP_SEQ`` +^^^^^^^^^^^^^^^^^^^^^^^ + +Decrease sequence number in the outermost TCP header. + +Using this action on non-matching traffic will result in undefined behavior, +depending on PMD implementation. + +.. _table_rte_flow_action_dec_tcp_seq: + +.. table:: DEC_TCP_SEQ + + +-----------+------------------------------------------+ + | Field | Value | + +===========+==========================================+ + | ``value`` | Value to decrease TCP sequence number by | + +-----------+------------------------------------------+ + +Action: ``INC_TCP_ACK`` +^^^^^^^^^^^^^^^^^^^^^^^ + +Increase acknowledgment number in the outermost TCP header. + +Using this action on non-matching traffic will result in undefined behavior, +depending on PMD implementation. + +.. _table_rte_flow_action_inc_tcp_ack: + +.. table:: INC_TCP_ACK + + +-----------+------------------------------------------------+ + | Field | Value | + +===========+================================================+ + | ``value`` | Value to increase TCP acknowledgment number by | + +-----------+------------------------------------------------+ + +Action: ``DEC_TCP_ACK`` +^^^^^^^^^^^^^^^^^^^^^^^ + +Decrease acknowledgment number in the outermost TCP header. + +Using this action on non-matching traffic will result in undefined behavior, +depending on PMD implementation. + +.. _table_rte_flow_action_dec_tcp_ack: + +.. table:: DEC_TCP_ACK + + +-----------+------------------------------------------------+ + | Field | Value | + +===========+================================================+ + | ``value`` | Value to decrease TCP acknowledgment number by | + +-----------+------------------------------------------------+ + Negative types ~~~~~~~~~~~~~~ diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c index 3277be1..ed4e643 100644 --- a/lib/librte_ethdev/rte_flow.c +++ b/lib/librte_ethdev/rte_flow.c @@ -143,6 +143,10 @@ struct rte_flow_desc_data { MK_FLOW_ACTION(SET_TTL, sizeof(struct rte_flow_action_set_ttl)), MK_FLOW_ACTION(SET_MAC_SRC, sizeof(struct rte_flow_action_set_mac)), MK_FLOW_ACTION(SET_MAC_DST, sizeof(struct rte_flow_action_set_mac)), + MK_FLOW_ACTION(INC_TCP_SEQ, sizeof(struct rte_flow_general_action)), + MK_FLOW_ACTION(DEC_TCP_SEQ, sizeof(struct rte_flow_general_action)), + MK_FLOW_ACTION(INC_TCP_ACK, sizeof(struct rte_flow_general_action)), + MK_FLOW_ACTION(DEC_TCP_ACK, sizeof(struct rte_flow_general_action)), }; static int diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index c0fe879..3b0e262 100644 --- a/lib/librte_ethdev/rte_flow.h +++ b/lib/librte_ethdev/rte_flow.h @@ -1651,6 +1651,46 @@ enum rte_flow_action_type { * See struct rte_flow_action_set_mac. */ RTE_FLOW_ACTION_TYPE_SET_MAC_DST, + + /** + * Increase sequence number in the outermost TCP header. + * + * Using this action on non-matching traffic will result in + * undefined behavior, depending on PMD implementation. + * + * See struct rte_flow_general_action. + */ + RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ, + + /** + * Decrease sequence number in the outermost TCP header. + * + * Using this action on non-matching traffic will result in + * undefined behavior, depending on PMD implementation. + * + * See struct rte_flow_general_action. + */ + RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ, + + /** + * Increase acknowledgment number in the outermost TCP header. + * + * Using this action on non-matching traffic will result in + * undefined behavior, depending on PMD implementation. + * + * See struct rte_flow_general_action. + */ + RTE_FLOW_ACTION_TYPE_INC_TCP_ACK, + + /** + * Decrease acknowledgment number in the outermost TCP header. + * + * Using this action on non-matching traffic will result in + * undefined behavior, depending on PMD implementation. + * + * See struct rte_flow_general_action. + */ + RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK, }; /** @@ -2123,6 +2163,26 @@ struct rte_flow_action_set_mac { }; /* + * @warning + * @b EXPERIMENTAL: this union may change without prior notice + * + * General integer type, can be expanded as needed. +*/ +union rte_flow_integer { + rte_be32_t be32; +}; + +/** + * @warning + * @b EXPERIMENTAL: this structure may change without prior notice + * + * General struct, for use by actions that require a single integer value. + */ +struct rte_flow_general_action { + union rte_flow_integer integer; +}; + +/* * Definition of a single action. * * A list of actions is terminated by a END action. -- 1.8.3.1