From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88D3545AF9; Thu, 10 Oct 2024 02:49:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D27C402E3; Thu, 10 Oct 2024 02:49:19 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2082.outbound.protection.outlook.com [40.107.243.82]) by mails.dpdk.org (Postfix) with ESMTP id AA20A4025E for ; Thu, 10 Oct 2024 02:49:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EHEMSNuJJtqevmjxCYDii8MY/ZpucJ3YIr42gqVcIndv2qEdjjJ0vBQ6jOwTm3kQmPRcqkaLLIs2j3ekuQQADIKYzDaVzsex8WL5yMl0gTZMaH/7p48rGux6gWt5PHwVpjiYmLG3cGVT/F/DatS4RxorziNG+i1F3cCc1aIHBn4SKOe8lJ9e6d8YrSb0TbWKb9zrIJhhRbekaOcbjnqXDcV3dRcwQb4Rx/kSCQb5EkLavX63acPC+RM1t07li/KMaH1zm3fXPMx106+ywWE9qBb3VVIfhwaF3FP5uyN2oZ1KRaNnRwOpBznqt00B/5zxmg6Y1yfwHDLNe/yj1UOFmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gAaHhRw6u7GQzo8GbJgrplz0oqby00P5MLo6NhIFfqs=; b=j1rB6mltlZs3yGUrqEG2gTZOtIbIjiXwxmG2EYD32c+9BTKe12+sMZuJs/Q98eAY2WUeM3z0gYlsDvzPG3V5fQAXqCLlmVh8MRx5XhP5WKI7JtvoMQew/3rAD2f/3OibUEBYgIdD3/uf+nKGNx7ycbdfO1o9AOjpz8fzZ+0Fd1k4KbT7tkhe912NVXYOL+APidl2oJt8TE7774no17f9agsO9EatvUC3kYQ5wLTcdaNPBn3obq6aE4cxITkxaxpr+vdBeiVOj4GQRNbJu8IP8PZD+/uc/zpisNK8mcLcBnUao/h6nD8n0hqVgcT6ZS/yCSKOP0Mc7DjRSpbtA6hngA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gAaHhRw6u7GQzo8GbJgrplz0oqby00P5MLo6NhIFfqs=; b=Zi8+FAizV2IpwTkPu6SgaLDqmQwp4xGwgZS4pdzwx7qsVgsb2ZZO1O4hMCNmdiD4tk3KEAXqGWOMqXrbm6131OXvjNLXZQlLosr7s+mgNwSzGVOcLbTv1Er7hEJ1IY1nxHAsyF9GXE2r+ZOaDPXIB1tgZxs4OTKgCKPx8IN+3Zk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by CY8PR12MB7338.namprd12.prod.outlook.com (2603:10b6:930:52::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.16; Thu, 10 Oct 2024 00:49:15 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8026.020; Thu, 10 Oct 2024 00:49:15 +0000 Message-ID: <02390115-de83-48be-b410-b1b94e5a9dea@amd.com> Date: Thu, 10 Oct 2024 01:49:05 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs To: David Marchand Cc: Akhil Goyal , dev@dpdk.org, Dodji Seketeli , thomas@monjalon.net, hemant.agrawal@nxp.com, anoobj@marvell.com, pablo.de.lara.guarch@intel.com, fiona.trahe@intel.com, declan.doherty@intel.com, matan@nvidia.com, g.singh@nxp.com, fanzhang.oss@gmail.com, jianjay.zhou@huawei.com, asomalap@amd.com, ruifeng.wang@arm.com, konstantin.v.ananyev@yandex.ru, radu.nicolau@intel.com, ajit.khaparde@broadcom.com, rnagadheeraj@marvell.com, mdr@ashroe.eu References: <20240905101438.3888274-1-gakhil@marvell.com> <10591cfb-d78e-4d50-9bb5-f6d1246662b3@amd.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0485.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::22) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|CY8PR12MB7338:EE_ X-MS-Office365-Filtering-Correlation-Id: 7617a72d-c762-4f63-1d12-08dce8c55d50 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VVc0OUxHT25RSjJLM2lHdlZYU1ZFU2NQdFFRbm1vc2xJQkc2R1NzTzA3VEFw?= =?utf-8?B?czZQRkc0ay9QeFFIMjN4c1lLVHpBZXkvaEI5WWlFNk0wRzlxYW9mNkNRTy9n?= =?utf-8?B?SW1WZXZ1cVhxeldMREFXMlBOZmNkTGFTQkM4blc4UnlSMXYwTkNPODRSVFNK?= =?utf-8?B?SVg1SStmeHhESXc1NWpFN21LeTRYbVU1NXE3ZjRyUmkzc3RqQjZIWVZBYmVl?= =?utf-8?B?a0Urai9wckdaQzlkbWE0UFhKTHVXTnVocXgza3hhZWtkYUJYQjF5K2NIa2xx?= =?utf-8?B?a04rWmVMQjYrczlKMGhRTUVVdG5ZWkNKZE50djAwdkltT2Yrd3MvakFSZTIz?= =?utf-8?B?RGttYitiOEpVdlNTMExJcGtWVm0rajdjUkRWNTNJUG1CUE1RL2dmU0tteTVM?= =?utf-8?B?VkVoWWJ2c2d5YVRDS3crTnJrRFFDOFJNSUt3MjdaRU9JUjQxMEhHVm0zY3dz?= =?utf-8?B?d2I2MHBwcUlOUEU0c0ROeFRWa3R6azMvSDM3UnVFMjZva3V5K0JUSkZCekFq?= =?utf-8?B?bXJzakhQMVJBR2hxSHZFTFM4bWc4SHlpZFdLMkkwQks2SHp5RHd3eVd0QzVk?= =?utf-8?B?enUyL1Z2dHFZQWlicjhqRGpheE1LdmpObEdxd1o2ZGYwWTN5VEQwN1JWVEpn?= =?utf-8?B?c2FNOVI0a2lWbHJXYiszL0QxcTlsTk5vbndrdTNhYlMwRmFZV0ZveTlOWTgz?= =?utf-8?B?TGFkcGk4UjdiMjBzdHRJYXJONXhLUC9aMXRtK1lrTkxXSi9adE9ZYVc5SGJF?= =?utf-8?B?UnNVU3ZJUE4rVVBHZXUyVDlDM3ZtdTUxaGZBMkU5WmMxK3ZHdEJqSHJkS0Uy?= =?utf-8?B?ejlHU0RqakJCRjJSSDl1VmxhcEtwL21BbDhOTnZIODZjN3dabWxqV0ZkeER3?= =?utf-8?B?d0pQdDU2UUpmaE0wa3VMd3pMb2ZzRVpKM2pSYkl1dFVoWE9NQTJuSUg1czhN?= =?utf-8?B?NVVxU1FmVnl3c0hubzgvcW1HNnFJUTB1b0pndWF0eGc0NWZFU08zZndjWWNi?= =?utf-8?B?Rkgxa0JFdDg0Uk1ldngyQm5RTWxHQmVRNFdoVW5KK0MrVHdCZmh3a3NZbHk4?= =?utf-8?B?MEpSUHE5WmpQLzhEQ0NDUTczNEhBNDdFY2M0bk11TGw0T0RmQ2lBMjE4Q2Jq?= =?utf-8?B?SndzRDBQNjNQdmNzZUlPdnh1dzVNNm9yM2RqS05IeGRjUFVYbDdHcHhQUDN1?= =?utf-8?B?VnNSV2JjRDdxQkFiLzgzQzZkbHl2OVlwMU9rM1RHNFVKbXZacno2RXBFbWlz?= =?utf-8?B?NjJraUZsVmJnZUd5czJ3SUMyWlZ4OGpiQ2lDWHY1NDFwL0Z0VmxodGxYL0J5?= =?utf-8?B?Tjhmanp4TXBua3FmK3FmbHdJWThqb0xZZVhmczRBODBlak1FMjRzMm95dnl5?= =?utf-8?B?SEQzM1pWUWYveUNsdXM4b3NkTXpyVS9zQjJBUFdOdys0Um9xVnJ0RGJHbldO?= =?utf-8?B?NWszcFpZMEhMb013MTBvK3RZTCt3MUcyQXIzaVB1TGt1VkQzMEFCaERnUk04?= =?utf-8?B?SzZ2SmY1MFlKVE1TSGo1anFiMzV2eEl4cjFFbzlUeFEzbzNBcmFERStaNGNv?= =?utf-8?B?SU5CejlsUTZod3A0ZWFvU3FVd3UrYkFYOW5ob2x4V2JFNEVOSUtQLzdYdDU5?= =?utf-8?Q?wsA8AkbmBp1KS6iGMSN2FxIBMdc+0cX/p5Rcv6wSMLtI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(7416014)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXFtTWVva1JTeVoxU0NZOUUxdW9Ocjg3U2tyMnpWbmtaSzdPNEtNZ3UzMzB0?= =?utf-8?B?cG9TNG9KU0d6L3BHSGRhamsxcTd3WEV4OWdyK1FGaWlab2k4RVpub05SbEFk?= =?utf-8?B?dkNoZnFia0ErVDdZU0lnTG4wQTROVmxZSkVqandjOXFLd1FNSTVYdEFQdlg5?= =?utf-8?B?L21VZUY2TGlzTjQwRlUxZEJtS0pnNTFRVnpaQVpybjZqM3JjbE1hbW5LelZW?= =?utf-8?B?RDZHMlh4YXBmVkRDdmR3dEEzaGx2WGJWOWQzMlZvdUFsMkpVQWZiMGE2blZk?= =?utf-8?B?R2RwdzBWMmo4eDkxNGF6VW1yczI0UzF5ZjhNMXpNT2VnV2NLT2dIRTZ2Q21B?= =?utf-8?B?UWtUYXB2RlB1SkI5MURqTDJrQllYSCtldzBXWHBvRkYra2UwR1VVb0I3ZDh1?= =?utf-8?B?TjBmVnhBSVRDTHBkbi9HQ21RNDMvZnVER0ZrQ3lZVExKNW9aSjlocGNwekQz?= =?utf-8?B?TzFnU1hMbThiUStsWWhHSWFNU08yaE84RVBzYjFzcmY1WU02MFRvRW1NRk5k?= =?utf-8?B?ditwQmFtZW8wamREK3ZSTktKVDN1MG1NOXFwQUxGcFg3MklxSmJkdnZmUFJD?= =?utf-8?B?MU9sNUNOUGhkSzF1ZVhNeHNOYzVmaUo4SjN3Q2k0VkxhY3RQYnF5NW9kc0Rx?= =?utf-8?B?RWl4bHFVSVRKb2hsNzh0ak8zRGt3TThLVkpIMnZ3MnVzUjNZMWZDQlkzNGdv?= =?utf-8?B?Vm5TMTFzdmEycTY4WGYzY1FXeFpKU0tBdFNNbGJuYlh4SHU3Rjhka3lGU2VP?= =?utf-8?B?RXJoUWxpbVRvcWN3NDZXMkdhbzlscG9vbVBGQlFBZU5qWTlWZEFTR0dLNmtx?= =?utf-8?B?MWVDeitHMjhXQzV2S2lNcEtHUEtlZXNWRUNPNkx1U3NlV1dsaHpiSXBnRUdz?= =?utf-8?B?TkZvaVY2Q2FIY1hqRzlKRlRYNE5mbWhmczVXSjBTeWs0ZytXQnZ4S09UR1pY?= =?utf-8?B?SWgxY1NQS3E2NVhjVlRBcFdIK0FEQnMwREFGZzVPUXBnOHVMNkJUK3Ztd3J2?= =?utf-8?B?M1FxaEhkWE5BZ0s4NXdrZkFJcndlUC96cEhaWm91b0hhN2l5Wk5iNm45WXlR?= =?utf-8?B?RlBaQnVnR1VzT2VRMDkvZ2NkQ2JXakwva2RJU3FHakRuY1VzdmxBTzcvajl5?= =?utf-8?B?d2k4cmdLYWVueG1UMTg5dFU2Qm00cEVBT2Z3bTkwaFlVTldydzRYY0VObk5L?= =?utf-8?B?MXpnSWtRWkdiakU3am5zbmFSTWNVUmFWZFlhUlNteEFUNElHcTRVTDhEdkc1?= =?utf-8?B?eCtmTGtoWWQwd0hjeXUzclZRNTRCRjdqSzI3bTdQdmozOFlJdi9HNFczR3JF?= =?utf-8?B?UFJzOWxITkJWVFdORkcxSmxJd21lNEZlMWlhQkVmc0NYVGpBNlJXcXZOdWFV?= =?utf-8?B?MTY3UC9OODArNmNCMDY1dm02U1dNUEVnUFRPV2ZvUWFWdW9tZG5DQkRiekJE?= =?utf-8?B?bVd5TEtMSHlDZTNydERXdGlRNjg5bGdGaUNrTmR1T2tpKzlOTERCUWRkbm52?= =?utf-8?B?RmkzRnZCMTBKaFFkYmFmZFFRYkoxSTdRMTRuNGpwU1MyN1BQTTBQaWpsdTdY?= =?utf-8?B?SEtIdGE0Zlp4ZC81MUxXTFhza050c1RPREFWUHliMElpUGxPNG1sSGNWWE9w?= =?utf-8?B?SHYweTR2bkJ5dGN3MVpDU2NENERhOTk2VnBqRS95OW9qY3orY1FGc0g5eTNW?= =?utf-8?B?UkI2c2ZXaDBQektLZmhWWDhpNlVKei9pT1JrYjlEUzFCODNkb0pybE5ZTy8r?= =?utf-8?B?VHlwYjdnOFZqQjVIMW1GY29MVmJKY0hNcE5HZlNRejhSVnVmcVFXZ29oeUZF?= =?utf-8?B?dkZBUzhDbVh2bXc1NTVwSm5qWk02TC9hSU9XU2xCb0gxcS85K3p5NUF5RDd6?= =?utf-8?B?TWpRcHRvTmZ2K2tKQThRUDNxR0h6bGVnRjVlS3FBNWNqcHRYaEd6Mnh5OUNz?= =?utf-8?B?ZGRLTXdCUkFhVGxuT0pZaGlVQ1R5bGN3NzBGSERSWVpxbVVtU2wxR1lKZlBo?= =?utf-8?B?ZUt1M0NxOTI5bThSSjVVRWVJZXZNblNyd29UTjIvYk5uUks5Vk5SNFJkNXpq?= =?utf-8?B?OSt2OTM4WGQ0cDhlbjlhM2ppNHI3ZkYwWnMvT29KaDYyUEdDOEY3ZFB2TkN6?= =?utf-8?Q?0Wo85l2J+NGOkiZ7fktSZFZoE?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7617a72d-c762-4f63-1d12-08dce8c55d50 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2024 00:49:15.3640 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JA20UPag7WAn4xQP6VSMHfW30NCNFNnSZCX7FNQ1b+5m8S45AtdZr+dA1f8/arPo X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7338 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/4/2024 8:04 AM, David Marchand wrote: > On Fri, Oct 4, 2024 at 5:55 AM Ferruh Yigit wrote: >> >> On 9/5/2024 11:14 AM, Akhil Goyal wrote: >>> Replace *_LIST_END enumerators from asymmetric crypto >>> lib to avoid ABI breakage for every new addition in >>> enums with inline APIs. >>> >>> Signed-off-by: Akhil Goyal >>> --- >>> This patch was discussed in ML long time back. >>> https://patches.dpdk.org/project/dpdk/patch/20211008204516.3497060-1-gakhil@marvell.com/ >>> Now added inline APIs for getting the list end which need to be updated >>> for each new entry to the enum. This shall help in avoiding ABI break >>> for adding new algo. >>> >> >> Hi Akhil, >> >> *I think* this hides the problem instead of fixing it, and this may be >> partially because of the tooling (libabigail) limitation. >> >> This patch prevents the libabigail warning, true, but it doesn't improve >> anything from the application's perspective. >> Before or after this patch, application knows a fixed value as END value. >> >> Not all changes in the END (MAX) enum values cause ABI break, but tool >> warns on all, that is why I think this may be tooling limitation [1]. >> (Just to stress, I am NOT talking about regular enum values change, I am >> talking about only END (MAX) value changes caused by appending new enum >> items.) >> >> As far as I can see (please Dodji, David correct me if I am wrong) ABI >> break only happens if application and library exchange enum values in >> the API (directly or within a struct). > > - There is also the following issue: > A library publicly exports an array sized against a END (MAX) enum in the API. > https://developers.redhat.com/blog/2019/05/06/how-c-array-sizes-become-part-of-the-binary-interface-of-a-library > I see. And Dodji explained this requires source code to detect. I don't remember seeing a public array whose size is defined by an enum, are you aware of any instance of this usage? > I had made comments for an issue in the cryptodev library in the past: > https://inbox.dpdk.org/dev/CAJFAV8xs5CVdE2xwRtaxk5vE_PiQMV5LY5tKStk3R1gOuRTsUw@mail.gmail.com/ > > > - Sorry to deviate from the _END enum discussion that tries to define > a solution for all cases, but all I see in the cryptodev patch is a > need for an enumerator... for an internal unit test. > From the RFC patch, I would simply change the > rte_crypto_asym_xform_type_list_end helper into a non inline symbol > and mark it __rte_internal, or move this helper to a non public header > used by the unit test. > > Or add a (internal) rte_crypto_asym_xform_type_next_op() used through > a a RTE_CRYPTO_FOREACH_ASYM_OP() macro. > >