From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B5FEA0546; Fri, 14 Feb 2020 02:02:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EF9841BFF9; Fri, 14 Feb 2020 02:02:17 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 821CA1BFF8 for ; Fri, 14 Feb 2020 02:02:15 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2020 17:02:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,438,1574150400"; d="scan'208";a="432864713" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 13 Feb 2020 17:02:12 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 13 Feb 2020 17:02:12 -0800 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 14 Feb 2020 09:02:10 +0800 Received: from shsmsx602.ccr.corp.intel.com ([10.109.6.142]) by SHSMSX602.ccr.corp.intel.com ([10.109.6.142]) with mapi id 15.01.1713.004; Fri, 14 Feb 2020 09:02:10 +0800 From: "Zhang, Xiao" To: "Ye, Xiaolong" CC: "dev@dpdk.org" , "orika@mellanox.com" , "Zhang, Qi Z" , "Su, Simei" , "Iremonger, Bernard" Thread-Topic: [dpdk-dev] app/testpmd: parse flow command line for AH Thread-Index: AQHV4ix65QHH0VpmnE+LEbTebkEcoagYKAqAgAG4HoA= Date: Fri, 14 Feb 2020 01:02:10 +0000 Message-ID: <024705529907439f906b002e8d665260@intel.com> References: <1581570460-27068-1-git-send-email-xiao.zhang@intel.com> <20200213064559.GQ80720@intel.com> In-Reply-To: <20200213064559.GQ80720@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzRiYzBlOWQtNWQ4NC00ZjliLTgxNWYtMTNjMjlkMjUzMzFhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTUEydmZzNVF0T21JTUJpN0xCWDdTUGVqUHdyT3hzdzFsa1hyTVRqSE5HQUYwK1JWOUFaSml5aTFidCt6QThUSyJ9 dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] app/testpmd: parse flow command line for AH X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ye, Xiaolong > Sent: Thursday, February 13, 2020 2:46 PM > To: Zhang, Xiao > Cc: dev@dpdk.org; orika@mellanox.com; Zhang, Qi Z ; > Su, Simei ; Iremonger, Bernard > > Subject: Re: [dpdk-dev] app/testpmd: parse flow command line for AH >=20 > Hi, Xiao >=20 > On 02/13, Xiao Zhang wrote: > >add ITEM_AH > >add ITEM_AH_SPI >=20 > Better to add some descriptive sentence about this patch in commit log in= stead > of some simple bullets. Yes, added more description in v2 patch. Thanks, Xiao >=20 > Thanks, > Xiaolong >=20 > > > >Signed-off-by: Xiao Zhang > >--- > > app/test-pmd/cmdline_flow.c | 29 +++++++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > > >diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > >index c2cc4c5..680cb1c 100644 > >--- a/app/test-pmd/cmdline_flow.c > >+++ b/app/test-pmd/cmdline_flow.c > >@@ -220,6 +220,8 @@ enum index { > > ITEM_L2TPV3OIP_SESSION_ID, > > ITEM_ESP, > > ITEM_ESP_SPI, > >+ ITEM_AH, > >+ ITEM_AH_SPI, > > > > /* Validate/create actions. */ > > ACTIONS, > >@@ -768,6 +770,7 @@ static const enum index next_item[] =3D { > > ITEM_TAG, > > ITEM_L2TPV3OIP, > > ITEM_ESP, > >+ ITEM_AH, > > END_SET, > > ZERO, > > }; > >@@ -1046,6 +1049,12 @@ static const enum index item_esp[] =3D { > > ZERO, > > }; > > > >+static const enum index item_ah[] =3D { > >+ ITEM_AH_SPI, > >+ ITEM_NEXT, > >+ ZERO, > >+}; > >+ > > static const enum index next_set_raw[] =3D { > > SET_RAW_INDEX, > > ITEM_ETH, > >@@ -2699,6 +2708,19 @@ static const struct token token_list[] =3D { > > .args =3D ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_esp, > > hdr.spi)), > > }, > >+ [ITEM_AH] =3D { > >+ .name =3D "ah", > >+ .help =3D "match AH header", > >+ .priv =3D PRIV_ITEM(AH, sizeof(struct rte_flow_item_ah)), > >+ .next =3D NEXT(item_ah), > >+ .call =3D parse_vc, > >+ }, > >+ [ITEM_AH_SPI] =3D { > >+ .name =3D "spi", > >+ .help =3D "security parameters index", > >+ .next =3D NEXT(item_ah, NEXT_ENTRY(UNSIGNED), item_param), > >+ .args =3D ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_ah, > spi)), > >+ }, > > /* Validate/create actions. */ > > [ACTIONS] =3D { > > .name =3D "actions", > >@@ -6444,6 +6466,9 @@ flow_item_default_mask(const struct rte_flow_item > *item) > > case RTE_FLOW_ITEM_TYPE_ESP: > > mask =3D &rte_flow_item_esp_mask; > > break; > >+ case RTE_FLOW_ITEM_TYPE_AH: > >+ mask =3D &rte_flow_item_ah_mask; > >+ break; > > default: > > break; > > } > >@@ -6541,6 +6566,10 @@ cmd_set_raw_parsed(const struct buffer *in) > > size =3D sizeof(struct rte_flow_item_esp); > > proto =3D 0x32; > > break; > >+ case RTE_FLOW_ITEM_TYPE_AH: > >+ size =3D sizeof(struct rte_flow_item_ah); > >+ proto =3D 0x33; > >+ break; > > default: > > printf("Error - Not supported item\n"); > > *total_size =3D 0; > >-- > >2.7.4 > >