From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8E4CA0577; Mon, 6 Apr 2020 16:28:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 345F52B96; Mon, 6 Apr 2020 16:28:37 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D4DAF2B86 for ; Mon, 6 Apr 2020 16:28:34 +0200 (CEST) IronPort-SDR: X5PeAbE7O3BS7ZBbzrtCmUXoRJN+oWqHahOQksHvdJ6j+KSlHDleiH72Jf5BJ1WGU6zW08cq+f //xtjZWdXc5w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2020 07:28:33 -0700 IronPort-SDR: OsC7wuDLSCQun6jjwHR/j9GNQHCdOE+y1Ewd19DjpJ8BhFcpsXBMIQvtegIi0db16BogqTTtIs f/yK5wzCTAKg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,351,1580803200"; d="scan'208";a="424377107" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.251.92.43]) ([10.251.92.43]) by orsmga005.jf.intel.com with ESMTP; 06 Apr 2020 07:28:30 -0700 To: David Coyle , dev@dpdk.org Cc: declan.doherty@intel.com, fiona.trahe@intel.com, pablo.de.lara.guarch@intel.com, brendan.ryan@intel.com, shreyansh.jain@nxp.com, hemant.agrawal@nxp.com, Akhil Goyal References: <20200403163656.60545-1-david.coyle@intel.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <02531729-4eee-3789-d1b7-54075312e66b@intel.com> Date: Mon, 6 Apr 2020 15:28:29 +0100 MIME-Version: 1.0 In-Reply-To: <20200403163656.60545-1-david.coyle@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 0/4] introduce multi-function processing support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/3/2020 5:36 PM, David Coyle wrote: > PLEASE NOTE: This patchset supercedes the following v1 patches which were > mistakenly added as stand-alone patches (apologies for any confusion this > may cause) > > https://patchwork.dpdk.org/patch/66733/ > https://patchwork.dpdk.org/patch/66735/ > https://patchwork.dpdk.org/patch/66736/ > > PLEASE NOTE ALSO: Support for QAT, which the following patch addressed, > has been dropped from this patchset and is now targetted at the next > release (v20.08) > > https://patchwork.dpdk.org/patch/66819/ > > > Introduction > ============ > > This patchset adds a new multi-function interface and a aesni_mb raw device > PMD which uses this interface. > > This patchset has already been discussed as part of the following RFC: > > http://mails.dpdk.org/archives/dev/2020-February/157045.html > http://mails.dpdk.org/archives/dev/2020-March/159189.html > > The main aim of this interface and raw PMDs is to provide a flexible and > extensible way of combining one or more packet-processing functions into a > single operation, thereby allowing these to be performed in parallel in > optimized software libraries or in a hardware accelerator. These functions > can include cryptography, compression and CRC/checksum calculation, while > others can potentially be added in the future. Performing these functions > in parallel as a single operation can enable a significant performance > improvement. > > > Background > ========== > > There are a number of byte-wise operations which are present and common > across many access network data-plane pipelines, such as Cipher, > Authentication, CRC, Bit-Interleaved-Parity (BIP), other checksums etc. > Some prototyping has been done at Intel in relation to the 01.org > access-network-dataplanes project to prove that a significant performance > improvement is possible when such byte-wise operations are combined into a > single pass of packet data processing. This performance boost has been > prototyped for both XGS-PON MAC data-plane and DOCSIS MAC data-plane > pipelines. > > The prototypes used some protocol-specific modifications to the DPDK > cryptodev library. In order to make this performance improvement consumable > by network access equipment vendors, a more extensible and correct solution > was required. > > Hence, the introduction of a multi-function interface, initially for use by > raw devices. In this patchset, a new aesni_mb raw device has been created > which uses this interface. > > NOTE: In a future DPDK release (currently targetting DPDK v20.08), a qat > raw device will also be added. As multiple raw devices will share the same > interface, the approach taken was to create a common interface > (i.e. multi-function) which can be used by these devices. This both cuts > down on code duplication across the devices and allows an application > access multiple devices using the same interface. > > > Use Cases > ========= > > The primary use cases for the multi-function interface and raw PMDs have > already been mentioned. These are: > > - DOCSIS MAC: Crypto-CRC > - Order: > - Downstream: CRC, Encrypt > - Upstream: Decrypt, CRC > - Specifications: > - Crypto: 128-bit AES-CFB encryption variant for DOCSIS as > described in section 11.1 of DOCSIS 3.1 Security > Specification > (https://apps.cablelabs.com/specification/CM-SP-SECv3.1) > - CRC: Ethernet 32-bit CRC as defined in > Ethernet/[ISO/IEC 8802-3] > > - XGS-PON MAC: Crypto-CRC-BIP > - Order: > - Downstream: CRC, Encrypt, BIP > - Upstream: BIP, Decrypt, CRC > - Specifications: > - Crypto: AES-128 [NIST FIPS-197] cipher, used in counter > mode (AES-CTR), as described in [NIST SP800-38A]. > - CRC: Ethernet 32-bit CRC as defined in > Ethernet/[ISO/IEC 8802-3] > - BIP: 4-byte bit-interleaved even parity (BIP) field > computed over the entire FS frame, refer to > ITU-T G.989.3, sections 8.1.1.5 and 8.1.2.3 > (https://www.itu.int/rec/dologin_pub.asp?lang=e&id= > T-REC-G.989.3-201510-I!!PDF-E) > > Note that support for both these chained operations is already available in > the Intel IPSec Multi-Buffer library. > > However, it is not limited to these. The following are some of the other > possible use-cases, which multi-function will allow for: > > - Storage: > - Compression followed by Encryption > - IPSec over UDP: > - UDP Checksum calculation followed by Encryption > > While DPDK's rte_cryptodev and rte_compressdev allow many cryptographic and > compression algorithms to be chained together in one operation, there is no > way to chain these with any error detection or checksum algorithms. And > there is no way to chain crypto and compression algorithms together. The > multi-function interface will allow these chains to be created, and also > allow any future type of operation to be easily added. I was thinking if the cryptodev can be used instead but this paragraph already seems explained it. But again can you please elaborate why rawdev is used? > > > Architecture > ============ > > The following diagram shows where the multi-function interface and raw > devices fit in an overall application architecture. > > +------------------------------------------------+ > | | > | Application | > | (e.g. vCMTS (DOCSIS), vOLT (XGS-PON), etc.) | > | | > +------------------------------------------------+ > | > +-----------------------|------------------------+ > | | DPDK | > | | | > | +---------------------+ | > | | | | > | | rte_rawdev | | > | | | | NOTE: > | +---------------------+ ____|______ 'MULTI-FUNCTION > | / \ / | INTERFACE' > | / \ / | is opaque to > | / \ / | rte_rawdev > | +--------------------------------+ | > | | MULTI-FUNCTION INTERFACE | | > | +--------------------------------+ | > | +------------+ +------------+ | > | | RAWDEV | | RAWDEV | | > | | AESNI-MB | | QAT | | > | | PMD | | PMD | | > | +------------+ +------------+ | NOTE: > | | | \________|_____ 'RAWDEV QAT PMD' > +--------------|------------------|--------------+ will be added in > | | next release > +------------+ +------------+ > | AESNI-MB | | QAT HW | > | SW LIB | | | > +------------+ +------------+ > > David Coyle (4): > raw/common: add multi-function interface > raw/aesni_mb: add aesni_mb raw device > test/rawdev: add aesni_mb raw device tests > app/crypto-perf: add support for multi-function processing > <...>