From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id F00D490F8 for ; Fri, 18 Aug 2017 18:13:14 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 18 Aug 2017 09:13:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,393,1498546800"; d="scan'208";a="301847906" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by fmsmga004.fm.intel.com with ESMTP; 18 Aug 2017 09:13:12 -0700 To: Nirmoy Das Cc: dev@dpdk.org References: <20170815095801.24988-1-ndas@suse.de> From: Ferruh Yigit Message-ID: <025e34de-65e8-a65c-53eb-bd2feb9e528c@intel.com> Date: Fri, 18 Aug 2017 17:13:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170815095801.24988-1-ndas@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] kni: fix build on SLE12 SP3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Aug 2017 16:13:15 -0000 Hi Nirmoy, On 8/15/2017 10:58 AM, Nirmoy Das wrote: > compilation error: > build/lib/librte_eal/linuxapp/kni/kni_net.c:215:5: error: ‘struct net_device’ has no member named ‘trans_start’ Commit log is too long, can you please break this line. > dev->trans_start = jiffies; > > Signed-off-by: Nirmoy Das > --- > lib/librte_eal/linuxapp/kni/compat.h | 32 +++++++++++++++++++++++++++++++- > 1 file changed, 31 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/linuxapp/kni/compat.h b/lib/librte_eal/linuxapp/kni/compat.h > index 6a1587b4e..81a4a5704 100644 > --- a/lib/librte_eal/linuxapp/kni/compat.h > +++ b/lib/librte_eal/linuxapp/kni/compat.h > @@ -8,6 +8,34 @@ > #define RHEL_RELEASE_VERSION(a, b) (((a) << 8) + (b)) > #endif > > +/* SuSE version macro is the same as Linux kernel version */ > +#ifndef SLE_VERSION > +#define SLE_VERSION(a,b,c) KERNEL_VERSION(a,b,c) > +#endif > +#ifdef CONFIG_SUSE_KERNEL > +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4, 4, 57)) > +/* SLES12SP3 is at least 4.4.57+ based */ > +#define SLE_VERSION_CODE SLE_VERSION(12, 3, 0) > +#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) ) There are checkpach warnings [1], can you please send a new version with them fixes? [1] ERROR:SPACING For spaces after, before the parenthesis and for missing space after "," in args list.. > +/* SLES12 is at least 3.12.28+ based */ > +#define SLE_VERSION_CODE SLE_VERSION(12,0,0) > +#elif ((LINUX_VERSION_CODE >= KERNEL_VERSION(3,0,61)) && \ > + (LINUX_VERSION_CODE < KERNEL_VERSION(3,1,0))) > +/* SLES11 SP3 is at least 3.0.61+ based */ > +#define SLE_VERSION_CODE SLE_VERSION(11,3,0) > +#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) ) > +/* SLES11 SP1 is 2.6.32 based */ > +#define SLE_VERSION_CODE SLE_VERSION(11,1,0) > +#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) ) > +/* SLES11 GA is 2.6.27 based */ > +#define SLE_VERSION_CODE SLE_VERSION(11,0,0) > +#endif /* LINUX_VERSION_CODE == KERNEL_VERSION(x,y,z) */ > +#endif /* CONFIG_SUSE_KERNEL */ > +#ifndef SLE_VERSION_CODE > +#define SLE_VERSION_CODE 0 > +#endif /* SLE_VERSION_CODE */ <...>