From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CBE8A00C2; Fri, 14 Oct 2022 11:35:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01354410F2; Fri, 14 Oct 2022 11:35:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 069CD410F1 for ; Fri, 14 Oct 2022 11:35:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665740122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8lnvORRt8fGQOG5tqrTepDSBwwq2214W+YRXoob0Vgw=; b=OfEZNgy2aBwbx5gHMevzNryOyelu1LxoIOJETBPZDc04bC9NhP2plZF3dyw5oUnT9vPhS6 2PXnROwCWqTt1gRtXFCn7GJwwXO/VjIub4wvT5jH3u7C+/sjDuztls1/xuy66wiDthch/m BZvEcdsKhXQIRs9XdDcJVOH1vaQSkAk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-45-ayIRWoo9MTOhjfucd0gKyw-1; Fri, 14 Oct 2022 05:35:18 -0400 X-MC-Unique: ayIRWoo9MTOhjfucd0gKyw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 191BF1C06903; Fri, 14 Oct 2022 09:35:18 +0000 (UTC) Received: from [10.39.208.28] (unknown [10.39.208.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A376CC04483; Fri, 14 Oct 2022 09:35:16 +0000 (UTC) Message-ID: <02643328-0fe9-05b8-122e-91a4cb4291f9@redhat.com> Date: Fri, 14 Oct 2022 11:35:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3 05/30] baseband/acc100: check turbo dec/enc input To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org References: <20221012025346.204394-1-hernan.vargas@intel.com> <20221012025346.204394-6-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20221012025346.204394-6-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/12/22 04:53, Hernan Vargas wrote: > Add NULL check for the turbo decoder and encoder input length. > > Fixes: 3bfc5f60403 ("baseband/acc100: add debug function to validate > input") Do not wrap the fixes line, even if checkpatch emits a warning. > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas > > Reviewed-by: Maxime Coquelin > --- > drivers/baseband/acc/rte_acc100_pmd.c | 23 ++++++++++++++++++----- > 1 file changed, 18 insertions(+), 5 deletions(-) > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c > index f636d4fa0f..3a008a3b88 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -1762,6 +1762,11 @@ validate_enc_op(struct rte_bbdev_enc_op *op, struct acc_queue *q) > return -1; > } > > + if (turbo_enc->input.length == 0) { unlikely()? > + rte_bbdev_log(ERR, "input length null"); > + return -1; > + } > + > if (turbo_enc->code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK) { > tb = &turbo_enc->tb_params; > if ((tb->k_neg < RTE_BBDEV_TURBO_MIN_CB_SIZE > @@ -1781,11 +1786,12 @@ validate_enc_op(struct rte_bbdev_enc_op *op, struct acc_queue *q) > RTE_BBDEV_TURBO_MAX_CB_SIZE); > return -1; > } > - if (tb->c_neg > (RTE_BBDEV_TURBO_MAX_CODE_BLOCKS - 1)) > + if (tb->c_neg > 0) { unlikely()? > rte_bbdev_log(ERR, > - "c_neg (%u) is out of range 0 <= value <= %u", > - tb->c_neg, > - RTE_BBDEV_TURBO_MAX_CODE_BLOCKS - 1); > + "c_neg (%u) expected to be null", > + tb->c_neg); > + return -1; > + } > if (tb->c < 1 || tb->c > RTE_BBDEV_TURBO_MAX_CODE_BLOCKS) { > rte_bbdev_log(ERR, > "c (%u) is out of range 1 <= value <= %u", > @@ -2286,6 +2292,11 @@ validate_dec_op(struct rte_bbdev_dec_op *op, struct acc_queue *q) > return -1; > } > > + if (turbo_dec->input.length == 0) { unlikely()? > + rte_bbdev_log(ERR, "input length null"); > + return -1; > + } > + > if (turbo_dec->code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK) { > tb = &turbo_dec->tb_params; > if ((tb->k_neg < RTE_BBDEV_TURBO_MIN_CB_SIZE > @@ -2306,11 +2317,13 @@ validate_dec_op(struct rte_bbdev_dec_op *op, struct acc_queue *q) > RTE_BBDEV_TURBO_MAX_CB_SIZE); > return -1; > } > - if (tb->c_neg > (RTE_BBDEV_TURBO_MAX_CODE_BLOCKS - 1)) > + if (tb->c_neg > (RTE_BBDEV_TURBO_MAX_CODE_BLOCKS - 1)) { unlikely()? > rte_bbdev_log(ERR, > "c_neg (%u) is out of range 0 <= value <= %u", > tb->c_neg, > RTE_BBDEV_TURBO_MAX_CODE_BLOCKS - 1); > + return -1; > + } > if (tb->c < 1 || tb->c > RTE_BBDEV_TURBO_MAX_CODE_BLOCKS) { > rte_bbdev_log(ERR, > "c (%u) is out of range 1 <= value <= %u",