From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C615643709; Sat, 16 Dec 2023 10:42:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC888402AA; Sat, 16 Dec 2023 10:42:54 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 800B9402A8 for ; Sat, 16 Dec 2023 10:42:53 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 33E5D66; Sat, 16 Dec 2023 12:42:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 33E5D66 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1702719772; bh=xBaiY1vYvVE/HAJYB2mN64fP+EWPs8VlFKM4YajEQqE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TEYkjsnklWfMR+aDQBIOxDUpMVYn4/gbU5nS/5P1auV3YH3g86/xk1sgYDVSqW1FE NhJ13J0vb0n78m+1h22lNU/3JWFX/aALK0h9Om/8+75EZIFvXmZtK03YUYsvKfqx0i BJhCBA/UM4HNkxB6Jo8cnShWtD1MspCu5jEZw4Uk= Message-ID: <0269e6ed-edac-46b1-8fd4-be6432ffb45d@oktetlabs.ru> Date: Sat, 16 Dec 2023 12:42:51 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 13/14] lib: replace logging helpers Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, stephen@networkplumber.org, mb@smartsharesystems.com, Konstantin Ananyev , Ruifeng Wang , Ori Kam , Yipeng Wang , Sameh Gobriel , Reshma Pattan , Anatoly Burakov , David Hunt , Sivaprasad Tummala , Ciara Power , Maxime Coquelin , Chenbo Xia References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231208145950.2184940-1-david.marchand@redhat.com> <20231208145950.2184940-14-david.marchand@redhat.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20231208145950.2184940-14-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/8/23 17:59, David Marchand wrote: > This is a preparation step before the next change. > > Many libraries have their own logging helpers that do not add a newline > in their format string. > Some previous changes fixed places where some of those helpers are > called without a trailing newline. > Using RTE_LOG_LINE in the existing helpers will ensure we don't > introduce new issues in the future. > > The problem is that if we simply convert to the RTE_LOG_LINE helper, > a future fix may introduce a regression since the logging helper > change won't be backported. > > To address this concern, rename existing helpers: backporting a call to > them will trigger some conflict or build issue in LTS branches. > > Note: > - bpf and vhost that still has some debug multilines messages, a direct > call to RTE_LOG/RTE_LOG_DP is used: this will make it easier to notice > such special cases, > - about previously publicly exposed logging helpers, when such helper is > not publicly used (iow in public inline API), it is removed from the > public API (this is the case for the member library), > > Signed-off-by: David Marchand For ethdev Reviewed-by: Andrew Rybchenko