From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68]) by dpdk.org (Postfix) with ESMTP id 83A0E1B21C for ; Thu, 9 Nov 2017 04:14:22 +0100 (CET) Received: by mail-pg0-f68.google.com with SMTP id j3so3615979pga.1 for ; Wed, 08 Nov 2017 19:14:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=qE0Qhh68Bww8IbAL7yeXok1PHUSjqAj2Yc+vPMhjE+8=; b=YGUEE3+VkG4/yCLBjVMuKQSF4XVoHkMqpwroQIxrbcc65UhfhaxSNhmQy5aUYItmFM LpvFv0DGvgFBaLWFptUF9Ik6lWc2RZHrAcYc7gBAnn7RzcOj6tnMugLygqjh87lf1QBP LTcYDuzQ4R9BsnbFwhWwJc+UHP8DDyR/hp5jxY1L6IK3w3nuae+aqaIe5fi/J4JQ+icX BBk95ImW6D3N3dqLZEX/WGwROIwGyOii0bbjE+P3AVnF1SaZaz/We7dFFglQLo678CtQ naeSE/9QK7k8Ac3dAdrdvm0fJqHJ88QlNKWY7J5N96dSdlukIpbRorJypNgmriQD3p/v r/Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=qE0Qhh68Bww8IbAL7yeXok1PHUSjqAj2Yc+vPMhjE+8=; b=o8+JU4WI42m8pChdqJ6u2Pr1rgjcnaxErCKmJNQbOPkFeEn8oQc4JnsXrM+R0pS4uq XkEoAwMC2ihgjHowMN03wv5R+ENkWl7+e9iigfW3D266KX6+Jd2W7DxZydk2s9G5mox4 SteMUhxk7kZckmvkgV+BOG57pjHh1aym/ixw/fuZZXH3qTMSGrdKzSGif2cFo+dJTeZg BVpb8rc9X7uxRTPyanBog98YH7PCMZiefKyCwFnRqsQOKJCaf5YVJmPMSPkMGUJ2j/YQ dNHuNXaniw7LrWs2HU635pa88qfyqFbf7BV3KCdiATe8WCruIe4hNYiA8u+6pKHIKGZu Y+Bw== X-Gm-Message-State: AJaThX5Fr0eQur2m+1Q9+9MjyMLaOcvwnBZQcP196DQUOzPXOxXplbHX gMThEZjABp/1crvVzJmGeac= X-Google-Smtp-Source: ABhQp+S5GHqiWcJ/ku16iXApwPS59ypqG+1jjprdoYznN26oS+tUbQTG5Qk0NVUTbJKGqK6l4uoQLg== X-Received: by 10.84.214.136 with SMTP id j8mr2494386pli.422.1510197261665; Wed, 08 Nov 2017 19:14:21 -0800 (PST) Received: from [0.0.0.0] (67.209.179.165.16clouds.com. [67.209.179.165]) by smtp.gmail.com with ESMTPSA id e71sm10399139pfk.55.2017.11.08.19.14.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Nov 2017 19:14:21 -0800 (PST) From: Jia He To: Bruce Richardson Cc: jerin.jacob@caviumnetworks.com, dev@dpdk.org, olivier.matz@6wind.com, konstantin.ananyev@intel.com, jianbo.liu@arm.com, hemant.agrawal@nxp.com, jia.he@hxt-semitech.com References: <1510121832-16439-1-git-send-email-hejianet@gmail.com> <20171108102814.GA7552@bricha3-MOBL3.ger.corp.intel.com> <9086316b-c16b-c42b-2d85-9b01fa2f66e1@gmail.com> Message-ID: <028263d0-44de-bd0c-c495-081588a0ad20@gmail.com> Date: Thu, 9 Nov 2017 11:14:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <9086316b-c16b-c42b-2d85-9b01fa2f66e1@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Nov 2017 03:14:22 -0000 On 11/9/2017 9:22 AM, Jia He Wrote: > Hi Bruce > > > On 11/8/2017 6:28 PM, Bruce Richardson Wrote: >> On Wed, Nov 08, 2017 at 06:17:10AM +0000, Jia He wrote: >>> for the code as follows: >>> if (condition) >>>     rte_smp_rmb(); >>> else >>>     rte_smp_wmb(); >>> Without this patch, compiler will report this error: >>> error: 'else' without a previous 'if' >>> >>> Signed-off-by: Jia He >>> Signed-off-by: jia.he@hxt-semitech.com >>> --- >>>   lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h >>> b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h >>> index 0b70d62..38c3393 100644 >>> --- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h >>> +++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h >>> @@ -43,8 +43,8 @@ extern "C" { >>>     #include "generic/rte_atomic.h" >>>   -#define dsb(opt)  { asm volatile("dsb " #opt : : : "memory"); } >>> -#define dmb(opt)  { asm volatile("dmb " #opt : : : "memory"); } >>> +#define dsb(opt) asm volatile("dsb " #opt : : : "memory"); >>> +#define dmb(opt) asm volatile("dmb " #opt : : : "memory"); >> Need to remove the trailing ";" I too I think. >> Alternatively, to keep the braces, the standard practice is to use >> do { ... } while(0) > If trailing ";" is not removed > the code: > if (condition) >     rte_smp_rmb(); > else >     anything(); > > will be like below after precompiling: > if (condition) >     asm volatile("dsb " "ld" : : : "memory");; > else >     anything(); > Then, the same error - error: 'else' without a previous 'if' > Ignore my words above，thanks sorry for the inconvenience. And I've sent out v4 in this mail thread. The ";" has been removed. If no more comments, I will send out v5 (2 patch sets for 17 and 18) -- Cheers, Jia -- Cheers, Jia