From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AC07A0503; Fri, 20 May 2022 10:59:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31889427ED; Fri, 20 May 2022 10:59:19 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 4A98840222 for ; Fri, 20 May 2022 10:59:18 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id D10D48A; Fri, 20 May 2022 11:59:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru D10D48A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1653037157; bh=VkDzzkjfwswVbmeWajjZ/PBTOJwkrYZZ1DVL2LhSaC4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nRn+JtqdkIlafrsOgIAjpkpkKu+Kln3XGZs/u1nFqpsr39zicq0tQ5+VcGhYuJSt0 AkYQ+XLtVnzdSW4iN+flRZKN9/cb208+GT2Xq9pfnx2omWrI+2BNZ8tx9xULKtYBea Kluv7OPWHZ8PBW33Spmq4fXcniVsCN5eTK1pa9cY= Message-ID: <02c76cd2-da56-7619-d52a-fa997bc81106@oktetlabs.ru> Date: Fri, 20 May 2022 11:59:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 05/12] net/hns3: fix an unreasonable memset Content-Language: en-US To: "Min Hu (Connor)" , dev@dpdk.org Cc: ferruh.yigit@intel.com, thomas@monjalon.net References: <20220519122917.2334-1-humin29@huawei.com> <20220519122917.2334-6-humin29@huawei.com> <1c148094-3550-b78e-7c23-1819582a83ff@oktetlabs.ru> <19acdf78-af14-25fa-a52b-8b1f96d3fcb3@huawei.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <19acdf78-af14-25fa-a52b-8b1f96d3fcb3@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/20/22 11:37, Min Hu (Connor) wrote: > Hi, Andrew , > > 在 2022/5/20 15:58, Andrew Rybchenko 写道: >> On 5/19/22 15:29, Min Hu (Connor) wrote: >>> From: Huisong Li >>> >>> This patch fixes an unreasonable memset. >>> >>> Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Huisong Li >>> Signed-off-by: Min Hu (Connor) >>> --- >>>   drivers/net/hns3/hns3_rxtx.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c >>> index 510802be05..5a2cfe5a54 100644 >>> --- a/drivers/net/hns3/hns3_rxtx.c >>> +++ b/drivers/net/hns3/hns3_rxtx.c >>> @@ -776,7 +776,7 @@ hns3vf_reset_all_tqps(struct hns3_hw *hw) >>>       int ret; >>>       uint16_t i; >>> -    memset(msg_data, 0, sizeof(uint16_t)); >>> +    memset(msg_data, 0, sizeof(msg_data)); >> >> It looks a bit suspicious. May be it is better to do: >>      memset(&msg_data, 0, sizeof(msg_data)); > I think this is too hard to understand for &msg_data is **p. > maybe it confuse others when use memset to operate level-2 pointer. msg_data == &amsg_data since it is an array > > >> It is pretty common mistake to do: >>      memset(p, 0, sizeof(p)); >> instead of >>      memset(p, 0, sizeof(*p)); >> when p is a pointer. >> I realize that msg_data is an array in this case, but >> I think it is better to avoid bad pattern in the code. >> >>>       ret = hns3_send_mbx_msg(hw, HNS3_MBX_QUEUE_RESET, 0, msg_data, >>>                   sizeof(msg_data), true, &reset_status, >>>                   sizeof(reset_status)); >> >> .