From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 84523A0C4E;
	Fri, 15 Oct 2021 09:02:41 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2533640041;
	Fri, 15 Oct 2021 09:02:41 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id D5D3C4003C
 for <dev@dpdk.org>; Fri, 15 Oct 2021 09:02:39 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 62A5E7F567;
 Fri, 15 Oct 2021 10:02:39 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 62A5E7F567
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1634281359;
 bh=KzjdSi6hjDviaUmFj25DPPcvRcG4VuzBIejRdN9QZ/I=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=E0dnWJsbM9WvwYIZw1auRh8os02OSrRA4Z+oBrf3gJwEXBCKN/A0sBwhLYyMxcTaM
 BkfPmTamQk1XhCQ+8ymFgTQvePK4j0GA/Yqf3pLQw+3qOsBTi4sP6eBMmmhJtKA9u/
 aASWqP3LORnO+mLAr3cuvN3u3B96jz5Y8CSs8bU0=
To: Stephen Hemminger <stephen@networkplumber.org>,
 David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, dkozlyuk@oss.nvidia.com, thomas@monjalon.net,
 Ray Kinsella <mdr@ashroe.eu>, Olivier Matz <olivier.matz@6wind.com>
References: <20211012072848.17741-1-david.marchand@redhat.com>
 <20211014192916.15046-1-david.marchand@redhat.com>
 <20211014123742.44574572@hermes.local>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <02df5a01-f698-e6d1-4c5c-1ffb4f9f7ef8@oktetlabs.ru>
Date: Fri, 15 Oct 2021 10:02:39 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211014123742.44574572@hermes.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] mempool: enforce valid flags at creation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/14/21 10:37 PM, Stephen Hemminger wrote:
> On Thu, 14 Oct 2021 21:29:16 +0200
> David Marchand <david.marchand@redhat.com> wrote:
> 
>> If we do not enforce valid flags are passed by an application, this
>> application might face issues in the future when we add more flags.
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>> Acked-by: Ray Kinsella <mdr@ashroe.eu>
>> ---
>> Changes since v1:
>> - fixed checkpatch warning,
>> - moved flags to validate them in the same order than parameters,
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> 

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>