From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Lior Margalit <lmargalit@nvidia.com>,
Parav Pandit <parav@nvidia.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"mdr@ashroe.eu" <mdr@ashroe.eu>
Subject: Re: [PATCH v4] bus: fix device iterator match from arguments
Date: Wed, 24 Nov 2021 13:00:06 +0000 [thread overview]
Message-ID: <02e22b94976f259d378e686ceb0496b0bf0d7395.camel@nvidia.com> (raw)
In-Reply-To: <20211124124524.25754-1-olivier.matz@6wind.com>
On Wed, 2021-11-24 at 13:45 +0100, Olivier Matz wrote:
> From: Xueming Li <xuemingl@nvidia.com>
>
> Device iterator RTE_DEV_FOREACH() failed to return devices from
> classifier like "class=vdpa", because matching name from empty kvargs
> returns no result. If device name not specified in kvargs, the function
> should iterate all devices.
>
> This patch allows empty devargs or devargs without name specified.
>
> Fixes: 6aebb942907d ("kvargs: add function to get from key and value")
>
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Reviewed-by: Xueming Li <xuemingl@nvidia.com>
> ---
> bug is specific to 21.11, no need to cc stable@dpdk.org
>
> v4:
> - disable unit test when net/null is not enabled
> v3:
> - add unit test
> v2:
> - use rte_kvargs_get() + strcmp instead of rte_kvargs_get_with_value()
Acked-by: Xueming Li <xuemingl@nvidia.com>
next prev parent reply other threads:[~2021-11-24 13:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 6:12 [PATCH] kvargs: " Xueming Li
2021-11-23 10:25 ` Olivier Matz
2021-11-23 11:25 ` Xueming(Steven) Li
2021-11-23 12:31 ` Olivier Matz
2021-11-23 12:49 ` Xueming(Steven) Li
2021-11-23 20:02 ` Olivier Matz
2021-11-24 10:21 ` Xueming(Steven) Li
2021-11-24 10:17 ` [PATCH v2] " Xueming Li
2021-11-24 11:07 ` Olivier Matz
2021-11-24 11:19 ` Xueming(Steven) Li
2021-11-24 11:02 ` [PATCH v3] bus: " Olivier Matz
2021-11-24 11:31 ` Xueming(Steven) Li
2021-11-24 11:43 ` Xueming(Steven) Li
2021-11-24 12:14 ` Olivier Matz
2021-11-24 12:45 ` [PATCH v4] " Olivier Matz
2021-11-24 13:00 ` Xueming(Steven) Li [this message]
2021-11-24 13:44 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02e22b94976f259d378e686ceb0496b0bf0d7395.camel@nvidia.com \
--to=xuemingl@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=lmargalit@nvidia.com \
--cc=mdr@ashroe.eu \
--cc=olivier.matz@6wind.com \
--cc=parav@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).