From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 36A9B1BBB0; Fri, 27 Oct 2017 02:49:49 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 26 Oct 2017 17:49:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,302,1505804400"; d="scan'208";a="914242428" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.24.13.44]) ([10.24.13.44]) by FMSMGA003.fm.intel.com with ESMTP; 26 Oct 2017 17:49:47 -0700 To: "Tan, Jianfeng" , "Mody, Rasesh" , Jingjing Wu , "Thotton, Shijith" , Gregory Etelson , "Patil, Harish" Cc: Thomas Monjalon , "dev@dpdk.org" , "stable@dpdk.org" , George Prekas , Sergio Gonzalez Monroy References: <20171020165511.47899-1-ferruh.yigit@intel.com> <44560a31-d8dc-b2e1-1589-95020fb654f3@intel.com> <5108b90a-5617-ea1a-ad41-c2eb83b8c1a1@intel.com> From: Ferruh Yigit Message-ID: <02e895a8-e1fa-7159-f0e9-b8b8f883ae27@intel.com> Date: Thu, 26 Oct 2017 17:49:46 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <5108b90a-5617-ea1a-ad41-c2eb83b8c1a1@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 00:49:50 -0000 On 10/26/2017 2:28 AM, Tan, Jianfeng wrote: > Hi Rasesh, > > > On 10/26/2017 7:43 AM, Mody, Rasesh wrote: >> Hi Ferruh, >> >>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit >>> Sent: Friday, October 20, 2017 9:58 AM >>> >>> On 10/20/2017 9:55 AM, Ferruh Yigit wrote: >>>> Remove device reset during application start, the reset for >>>> application exit still there. >>>> >>>> Reset in open removed because of following comments: >>>> 1- Device reset not completed when VF driver loaded, which cause VF PMD >>>> initialization error. >>>> Adding delay can solve the issue but will increase driver load time. >>>> >>>> 2- Reset will be issues all devices unconditionally, not very efficient >>>> way. >>>> >>>> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of >>>> device file") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Ferruh Yigit >>> Hi Jingjing, Shijith, Gregory, Harish, >>> >>> Can you please test this on top of current master (which has already Jingjin's >>> fix) ? >> The original FLR change during igb_uio open()/release() in DPDK17.08 also impacts BNX2X PMD and it exhibits the issues with bare metal testing. >> >> Now, we tested this change for BNX2X PMD using latest dpdk, which has this fix where FLR is invoked only in the release(). Good to hear this fixed the problem. >> However, we ran into an issue when trying to reload the testpmd application in quick succession. The pci reset, called during the igb_uio release() operation, is taking longer time and adapter is still doing the FLR when we relaunch the application. We see this behavior with bare metal testing. > > If we don't reset that device, it will continue working which is a more > serious issue IMO. +1 > How long does it take to reset BTW? I was wondering same thing. > > Thanks, > Jianfeng >