From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Ariel Otilibili <otilibil@eurecom.fr>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [PATCH 1/1] common/sfc_efx/base: remove unreachable code
Date: Sat, 21 Dec 2024 20:42:06 +0300 [thread overview]
Message-ID: <02eaeb6f-73e9-47bf-beee-72af2ac16d23@oktetlabs.ru> (raw)
In-Reply-To: <20241221132830.1100648-2-otilibil@eurecom.fr>
NACK
it is the base driver and corresponding code is unreachable with current
build options only.
On 12/21/24 16:27, Ariel Otilibili wrote:
> The default switch case ends with a goto; meaning these instructions are
> never reached.
>
> Coverity issue: 121742
> Fixes: 19b64c6ac3 ("net/sfc/base: import libefx base")
> Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
> --
> Cc: stable@dpdk.org
> Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
> drivers/common/sfc_efx/base/efx_mon.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/common/sfc_efx/base/efx_mon.c b/drivers/common/sfc_efx/base/efx_mon.c
> index ee449ef5eb..5706171abd 100644
> --- a/drivers/common/sfc_efx/base/efx_mon.c
> +++ b/drivers/common/sfc_efx/base/efx_mon.c
> @@ -80,9 +80,6 @@ efx_mon_init(
> goto fail2;
> }
>
> - emp->em_emop = emop;
> - return (0);
> -
> fail2:
> EFSYS_PROBE(fail2);
>
next prev parent reply other threads:[~2024-12-21 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-21 13:27 [PATCH 0/1] " Ariel Otilibili
2024-12-21 13:27 ` [PATCH 1/1] " Ariel Otilibili
2024-12-21 17:42 ` Andrew Rybchenko [this message]
2024-12-21 18:20 ` Ariel Otilibili-Anieli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02eaeb6f-73e9-47bf-beee-72af2ac16d23@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=otilibil@eurecom.fr \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).