From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7BBB745F08;
	Sat, 21 Dec 2024 18:42:09 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1B86E402A7;
	Sat, 21 Dec 2024 18:42:09 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 1B6AD40144;
 Sat, 21 Dec 2024 18:42:08 +0100 (CET)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B317B57
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1734802926;
 bh=FO88ofbtTxpZMBxRRxpzUbszg4clifuqiSYUrPnLMeI=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=dbwd8EAzqCDxrpqrom2ea1DfM+K/2n++Jp3zAvirO5Yi5JHYlBWR6Gci427vg9C+L
 GYH8OPRzmiyvrstuHBMZnhgadZ6GdjOqfUq37BntpBYnB5sf80egZb7rjaM133o6r0
 FoEDE6Zvl8UMGXjEz33uqYyZUikm+pm7Pl/CVoYg=
Received: from [192.168.1.126] (unknown [188.242.176.176])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B317B57;
 Sat, 21 Dec 2024 20:42:06 +0300 (MSK)
Message-ID: <02eaeb6f-73e9-47bf-beee-72af2ac16d23@oktetlabs.ru>
Date: Sat, 21 Dec 2024 20:42:06 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] common/sfc_efx/base: remove unreachable code
To: Ariel Otilibili <otilibil@eurecom.fr>, dev@dpdk.org
Cc: stable@dpdk.org
References: <20241221132830.1100648-1-otilibil@eurecom.fr>
 <20241221132830.1100648-2-otilibil@eurecom.fr>
Content-Language: en-US
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <20241221132830.1100648-2-otilibil@eurecom.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

NACK

it is the base driver and corresponding code is unreachable with current
build options only.

On 12/21/24 16:27, Ariel Otilibili wrote:
> The default switch case ends with a goto; meaning these instructions are
> never reached.
> 
> Coverity issue: 121742
> Fixes: 19b64c6ac3 ("net/sfc/base: import libefx base")
> Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
> --
> Cc: stable@dpdk.org
> Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
>   drivers/common/sfc_efx/base/efx_mon.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/common/sfc_efx/base/efx_mon.c b/drivers/common/sfc_efx/base/efx_mon.c
> index ee449ef5eb..5706171abd 100644
> --- a/drivers/common/sfc_efx/base/efx_mon.c
> +++ b/drivers/common/sfc_efx/base/efx_mon.c
> @@ -80,9 +80,6 @@ efx_mon_init(
>   		goto fail2;
>   	}
>   
> -	emp->em_emop = emop;
> -	return (0);
> -
>   fail2:
>   	EFSYS_PROBE(fail2);
>