From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 173F945629;
	Wed, 17 Jul 2024 04:15:15 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E501240299;
	Wed, 17 Jul 2024 04:15:14 +0200 (CEST)
Received: from smtpbgeu1.qq.com (smtpbgeu1.qq.com [52.59.177.22])
 by mails.dpdk.org (Postfix) with ESMTP id DD5BF4025F
 for <dev@dpdk.org>; Wed, 17 Jul 2024 04:15:12 +0200 (CEST)
X-QQ-mid: Yeas6t1721182499t212t61809
Received: from 3DB253DBDE8942B29385B9DFB0B7E889 (jiawenwu@trustnetic.com
 [220.184.255.174])
X-QQ-SSF: 00400000000000F0FVF000000000000
From: =?utf-8?b?Smlhd2VuIFd1?= <jiawenwu@trustnetic.com>
X-BIZMAIL-ID: 13288290825434386267
To: "'Ferruh Yigit'" <ferruh.yigit@amd.com>,
	<dev@dpdk.org>
References: <20240618071150.21564-1-jiawenwu@trustnetic.com>
 <20240716081653.449541-1-jiawenwu@trustnetic.com>
 <20240716081653.449541-2-jiawenwu@trustnetic.com>
 <7e4be130-746b-4ddd-8acb-b712663cfae9@amd.com>
In-Reply-To: <7e4be130-746b-4ddd-8acb-b712663cfae9@amd.com>
Subject: RE: [PATCH v2 2/2] net/ngbe: disable LLDP by default
Date: Wed, 17 Jul 2024 10:14:57 +0800
Message-ID: <02f401dad7ef$1f1e5c90$5d5b15b0$@trustnetic.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Content-Language: zh-cn
Thread-Index: AQHT4561YHDS+Zm68TKz6m0rT0fSVgHbH2OUAn86LQoCUfqrjLHSsa5A
X-QQ-SENDSIZE: 520
Feedback-ID: Yeas:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Jul 16, 2024 7:06 PM, Ferruh Yigit wrote:
> On 7/16/2024 9:16 AM, Jiawen Wu wrote:
> > --- a/drivers/net/ngbe/base/ngbe_hw.h
> > +++ b/drivers/net/ngbe/base/ngbe_hw.h
> > @@ -84,8 +84,8 @@ s32 ngbe_enable_rx_dma(struct ngbe_hw *hw, u32 regval);
> >  void ngbe_map_device_id(struct ngbe_hw *hw);
> >
> >  void ngbe_read_efuse(struct ngbe_hw *hw);
> > -u32 ngbe_fmgr_cmd_op(struct ngbe_hw *hw, u32 cmd, u32 cmd_addr);
> > -u32 ngbe_flash_read_dword(struct ngbe_hw *hw, u32 addr);
> > +s32 ngbe_fmgr_cmd_op(struct ngbe_hw *hw, u32 cmd, u32 cmd_addr);
> > +s32 ngbe_flash_read_dword(struct ngbe_hw *hw, u32 addr, u32 *data);
> >  void ngbe_set_ncsi_status(struct ngbe_hw *hw);
> >
> 
> Hi Jiawen,
> 
> Are above changes, and related changed caused by it, relevant to this
> patch? Changes seems unrelated with main functionality of this patch.

These changes are due to a flash read failure in the flow of disabling LLDP.
For the sake of this case, change the original flash read function.