From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E14945EB3; Mon, 16 Dec 2024 02:50:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE69240261; Mon, 16 Dec 2024 02:50:08 +0100 (CET) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 0D47C4025A; Mon, 16 Dec 2024 02:50:06 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4YBNBN3HDVz21nHM; Mon, 16 Dec 2024 09:48:12 +0800 (CST) Received: from dggemv703-chm.china.huawei.com (unknown [10.3.19.46]) by mail.maildlp.com (Postfix) with ESMTPS id 55B331400F4; Mon, 16 Dec 2024 09:50:02 +0800 (CST) Received: from kwepemn100009.china.huawei.com (7.202.194.112) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 16 Dec 2024 09:50:02 +0800 Received: from [10.67.121.59] (10.67.121.59) by kwepemn100009.china.huawei.com (7.202.194.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 16 Dec 2024 09:50:01 +0800 Message-ID: <0304e3a3-c277-aa2f-d77b-07a039856139@huawei.com> Date: Mon, 16 Dec 2024 09:50:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] test/bonding: fix active backup rx test To: Stephen Hemminger CC: , , Chas Williams , "Min Hu (Connor)" , Chengwen Feng , Bruce Richardson References: <20241213015158.10174-1-stephen@networkplumber.org> <8e824f6a-b271-1b2d-9a27-aed5cd27cb8f@huawei.com> <20241213085545.30b86af1@hermes.local> From: "lihuisong (C)" In-Reply-To: <20241213085545.30b86af1@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemn100009.china.huawei.com (7.202.194.112) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2024/12/14 0:56, Stephen Hemminger 写道: > On Fri, 13 Dec 2024 14:57:23 +0800 > "lihuisong (C)" wrote: > >> Hi Stephen, >> >> This patch looks good to me. >> >> But this test case still runs failure when I run "link_bonding_autotest" >> twice. like: >> --> >> ... >> EAL: Test assert configure_ethdev line 181 failed: rte_eth_dev_configure >> for port 7 failed >> EAL: Test assert initialize_bonding_device_with_members line 1138 >> failed: Failed to configure bonding port (7) in mode 3 with (4) members. >> EAL: Test assert >> test_broadcast_verify_member_link_status_change_behaviour line 4060 >> failed: Failed to initialise bonding device >>  + TestCase [62] : >> test_broadcast_verify_member_link_status_change_behaviour failed >> ETHDEV: Invalid port_id=7 >> EAL: Test assert configure_ethdev line 181 failed: rte_eth_dev_configure >> for port 7 failed >> EAL: Test assert test_reconfigure_bonding_device line 4162 failed: >> failed to reconfigure bonding device >>  + TestCase [63] : test_reconfigure_bonding_device failed >> ETHDEV: Invalid port_id=7 >>  + TestCase [64] : test_close_bonding_device succeeded >> ETHDEV: Invalid port_id=7 >> EAL: Test assert remove_members_and_stop_bonding_device line 659 failed: >> Failed to stop bonding port 7 >>  + ------------------------------------------------------- + >>  + Test Suite Summary : Link Bonding Unit Test Suite >>  + ------------------------------------------------------- + >>  + Tests Total :       65 >>  + Tests Skipped :      0 >>  + Tests Executed :    65 >>  + Tests Unsupported:   0 >>  + Tests Passed :       5 >>  + Tests Failed :      60 >>  + ------------------------------------------------------- + >> Test Failed >> >> >> I guess the bonding use case needs to close all bonding devices. > > The test has lots of issues that would make it bad to run twice. > Like leaking mbufs, etc. > But these always existed and will leave that to bonding maintainers to fix. ok, these issues aren't related to this patch and can be be fixed later. > .