From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 330C9A00C3; Wed, 8 Jun 2022 11:51:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BAA940689; Wed, 8 Jun 2022 11:51:52 +0200 (CEST) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id D17C64021D for ; Wed, 8 Jun 2022 11:51:50 +0200 (CEST) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 8ED433F325 for ; Wed, 8 Jun 2022 09:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1654681910; bh=nLp6a3B0yT5rnePT2F2WlTmpqJo6m3/kpjIvZaD+seo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EOg3oybvMtRjyEwXFac84FPvk2DsstNf3DQWn+00gLq6g5u3x8KOMiKnk1JAnUBvi apt4bCPolAcczHd4Ncc7D+Pb2GMEje8le+/DKec/xvgEkYNzChveuijWwoMXa+FTFD Mhz+eNYqKEtV/QmebIsI7nUOD5QSs27xkZEH+WYt/WZGNbYJi/+6vNlnj11cm+BhFd pE3bpj4+wIHOxxFqU6HhFJpAHNo34wPEEoYyryPo8U+5I9kALE+XZ5jiapoX1TdOqg CTkGKEK0Whmg8UTqS+6me8FjQ7LnWO6yhTMBxwFC0bQ0+Po3FLiJtTvnSrQso4u9U/ 5kz/lSORr7XkA== Received: by mail-wr1-f69.google.com with SMTP id d9-20020adfe849000000b00213375a746aso4140293wrn.18 for ; Wed, 08 Jun 2022 02:51:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nLp6a3B0yT5rnePT2F2WlTmpqJo6m3/kpjIvZaD+seo=; b=Mqfz4EYAQzMt3DuSurtNlbDNknmiXy56wEfIknxAXzVu2QCxFEPSAP6r0BNhwlX/NO 7mNMeQBPvNcIQ4wRwOk3moH2uzIOlzdQZE28AgsiCtCZQY+bzrPDfDEbPfoivbgrl4n+ Qmksge0RsAn5u/EJfYMOJaewlAXk0LUoOENFNevz//AwoSDCpIqjZ/Fbjv1C0rABpW2K 0THyCv9r+WWlDQeMKDWgqh86Ad1ThRrEbEFAqGmR+XdRxMu8AGoHESU6avSqh8Izc9Nl cB2ZATN2mfcEdLU26QnjSIBq+8CPbVASQRJ5lXSFIfBSWVYdfGg4Mvd6L6AURILmVgu3 c16g== X-Gm-Message-State: AOAM531xBBMUWrCWMxF/4h7JWPzjl79+Wt1NKwrDg5xYKo0eySBYq83X eP5kIWrrcpxou2KzKkg83tLliYYGzMAJyk/nGTPiCDX8TK6Qtczg95fa5CCBBkIamV2vFWeukIQ dN3VE2+jkHnKtjt/6jsQ5 X-Received: by 2002:a5d:43d2:0:b0:218:3fe6:4127 with SMTP id v18-20020a5d43d2000000b002183fe64127mr15357537wrr.62.1654681910218; Wed, 08 Jun 2022 02:51:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzam6qsU8e2Pjk35gTb+zQE2UgnR7sN4OeANmH32q05IOU78/NBQ50upY0A6zKLW8b3CbQrsw== X-Received: by 2002:a5d:43d2:0:b0:218:3fe6:4127 with SMTP id v18-20020a5d43d2000000b002183fe64127mr15357509wrr.62.1654681909916; Wed, 08 Jun 2022 02:51:49 -0700 (PDT) Received: from [192.168.123.67] (ip-062-143-094-109.um16.pools.vodafone-ip.de. [62.143.94.109]) by smtp.gmail.com with ESMTPSA id n22-20020a05600c3b9600b00397342e3830sm31492521wms.0.2022.06.08.02.51.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 02:51:49 -0700 (PDT) Message-ID: <0331e6c1-9b64-7f75-be7a-cef96f2a33ea@canonical.com> Date: Wed, 8 Jun 2022 11:51:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v4 0/8] Introduce support for RISC-V architecture Content-Language: en-US To: David Marchand , Stanislaw Kardach Cc: dev , Frank Zhao , Sam Grove , Marcin Wojtas , upstream@semihalf.com References: <20220531141307.253385-1-kda@semihalf.com> From: Heinrich Schuchardt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/8/22 10:41, David Marchand wrote: > On Tue, May 31, 2022 at 4:14 PM Stanislaw Kardach wrote: >> >> This patchset adds support for building and running DPDK on 64bit RISC-V >> architecture. The initial support targets rv64gc (rv64imafdc) ISA and >> was tested on SiFive Unmatched development board with the Freedom U740 >> SoC running Linux (freedom-u-sdk based kernel). >> I have tested this codebase using DPDK unit and perf tests as well as >> test-pmd, l2fwd and l3fwd examples. >> The NIC attached to the DUT was Intel X520-DA2 which uses ixgbe PMD. >> On the UIO side, since U740 does not have an IOMMU, I've used igb_uio, >> uio_pci_generic and vfio-pci noiommu drivers. >> >> Functional verification done using meson tests. fast-tests suite passing with >> the default config. >> >> PMD verification done using a Intel x520-DA2 NIC (ixgbe) and the test-pmd >> application. Packet transfer checked using all UIO drivers available for >> non-IOMMU platforms: uio_pci_generic, vfio-pci noiommu and igb_uio. >> >> The i40e PMD driver is disabled on RISC-V as the rv64gc ISA has no vector >> operations. >> >> RISCV support is currently limited to Linux as the time measurement frequency >> discovery is tied to reading a device-tree node via procfs. >> >> Clang compilation currently not supported due to issues with missing relocation >> relaxation. >> >> Commit 1 introduces EAL and build system support for RISC-V architecture >> as well as documentation updates. >> Commits 2-5 add missing defines and stubs to enable RISC-V operation in >> non-EAL parts. >> Commit 6 adds RISC-V specific cpuflags test. >> Commits 7-8 add RISC-V build testing to test-meson-builds.sh and github CI. > > Overall, the series lgtm. > It did not get much reviews, but the porting is straightforward and > clean enough. > > I'm waiting for some compilation to finish and I will merge it for 22.07-rc1. > > > Some comments that will probably require some followup patches for rc2: > > - I removed the known issue about --no-huge from the EAL patch. > This seems to be a generic issue that does not block the RISC V port > and can be re-submitted as a separate patch. > > > - I had some trouble with finding a right toolchain for test-meson-builds.sh. > The mentionned toolchains in the cross build guide don't work for me on FC36. > I managed to cross compile with a Bootlin toolchain, though I had to > adjust the cross compilation file. > I'll probably end up compiling my own toolchain later unless you have > a better idea. Please, consider building natively too. https://wiki.ubuntu.com/RISC-V describes setting setting up a virtual machine. > > At least the compilation in GHA works. > > > - The hardcoded pkg-config path in config/riscv/riscv64_linux_gcc does > not seem generic. > It is probably not a big issue, but I'd rather move it to a Ubuntu > specific cross compile meson file. > WDYT? > > > - I adjusted some coding style in some asm and some indentation and > wording in meson. > > > - The cross compilation guide mentions using > crossbuild-essential-riscv64 for Ubuntu. > We should switch to it in GHA. > Though after trying myself, there is an issue in the C++ headers check > in GHA for some acl header including rte_vect.h. > Can you have a look? > > > - There was a patch from Heinrich about native compilation, can you review it? [PATCH] Fix RISC-V builds http://mails.dpdk.org/archives/dev/2022-May/242749.html relates to PktGen. Best regards Heinrich