From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5664CA00C5; Wed, 14 Sep 2022 19:00:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 490D04021D; Wed, 14 Sep 2022 19:00:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 95ECC40156 for ; Wed, 14 Sep 2022 19:00:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663174848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RvlGpXrks+Y7FXez5IaDMqQTWOLftA0xFO7wG0DiRto=; b=Yjhexxz+PF8P6KdI8qFtCaRms33vnTty03dVxxo9Nrpx1Ng7kkqYsnRRW9KDN6sQR4ii+E pHtoDE3jEPji1O7U26HvwNEaUQOkGgOxHj4I8bgubFGsgA5dbhl7CO946s10hmXmWAFj6y XyOM/m9GEJtlJEc9HHJT2+ulUbK8eyo= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-615-M9M6Qwg-PLCS1yb5rk6vpw-1; Wed, 14 Sep 2022 13:00:45 -0400 X-MC-Unique: M9M6Qwg-PLCS1yb5rk6vpw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 273DA1C0519A; Wed, 14 Sep 2022 17:00:45 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D18932027061; Wed, 14 Sep 2022 17:00:43 +0000 (UTC) Message-ID: <0341bd20-0399-ca18-1534-802cabd9f53c@redhat.com> Date: Wed, 14 Sep 2022 19:00:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-4-hernan.vargas@intel.com> From: Maxime Coquelin Subject: Re: [PATCH v2 03/37] baseband/acc100: add function to check AQ availability In-Reply-To: <20220820023157.189047-4-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > It is possible for some corner case to run more batch enqueue than > supported. A protection is required to avoid that corner case. > Enhance all ACC100 enqueue operations with check to see if there is room > in the atomic queue for enqueueing batches into the queue manager > Check room in AQ for the enqueues batches into Qmgr Same as on patch 2. Reading the commit message, it sounds like a fix. > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 30 +++++++++++++++++------- > 1 file changed, 22 insertions(+), 8 deletions(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 0598d33582..7349bb5bad 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -3635,12 +3635,27 @@ acc100_enqueue_enc_tb(struct rte_bbdev_queue_data *q_data, > return i; > } > > +/* Check room in AQ for the enqueues batches into Qmgr */ > +static int32_t > +acc100_aq_avail(struct rte_bbdev_queue_data *q_data, uint16_t num_ops) > +{ > + struct acc100_queue *q = q_data->queue_private; > + int32_t aq_avail = q->aq_depth - > + ((q->aq_enqueued - q->aq_dequeued + > + ACC100_MAX_QUEUE_DEPTH) % ACC100_MAX_QUEUE_DEPTH) > + - (num_ops >> 7); > + if (aq_avail <= 0) > + acc100_enqueue_queue_full(q_data); Ok, forget my comment on patch 1, acc100_enqueue_queue_full() being used here. > + return aq_avail; > +} > + > /* Enqueue encode operations for ACC100 device. */ > static uint16_t > acc100_enqueue_enc(struct rte_bbdev_queue_data *q_data, > struct rte_bbdev_enc_op **ops, uint16_t num) > { > - if (unlikely(num == 0)) > + int32_t aq_avail = acc100_aq_avail(q_data, num); > + if (unlikely((aq_avail <= 0) || (num == 0))) > return 0; > if (ops[0]->turbo_enc.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK) > return acc100_enqueue_enc_tb(q_data, ops, num); > @@ -3653,7 +3668,8 @@ static uint16_t > acc100_enqueue_ldpc_enc(struct rte_bbdev_queue_data *q_data, > struct rte_bbdev_enc_op **ops, uint16_t num) > { > - if (unlikely(num == 0)) > + int32_t aq_avail = acc100_aq_avail(q_data, num); > + if (unlikely((aq_avail <= 0) || (num == 0))) > return 0; > if (ops[0]->ldpc_enc.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK) > return acc100_enqueue_enc_tb(q_data, ops, num); > @@ -3850,7 +3866,8 @@ static uint16_t > acc100_enqueue_dec(struct rte_bbdev_queue_data *q_data, > struct rte_bbdev_dec_op **ops, uint16_t num) > { > - if (unlikely(num == 0)) > + int32_t aq_avail = acc100_aq_avail(q_data, num); > + if (unlikely((aq_avail <= 0) || (num == 0))) > return 0; > if (ops[0]->turbo_dec.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK) > return acc100_enqueue_dec_tb(q_data, ops, num); > @@ -3863,11 +3880,8 @@ static uint16_t > acc100_enqueue_ldpc_dec(struct rte_bbdev_queue_data *q_data, > struct rte_bbdev_dec_op **ops, uint16_t num) > { > - struct acc100_queue *q = q_data->queue_private; > - int32_t aq_avail = q->aq_depth + > - (q->aq_dequeued - q->aq_enqueued) / 128; > - > - if (unlikely((aq_avail == 0) || (num == 0))) > + int32_t aq_avail = acc100_aq_avail(q_data, num); > + if (unlikely((aq_avail <= 0) || (num == 0))) > return 0; > > if (ops[0]->ldpc_dec.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK)