From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
by dpdk.org (Postfix) with ESMTP id 124341B375
for <dev@dpdk.org>; Thu, 18 Jan 2018 18:31:03 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
18 Jan 2018 09:31:02 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,378,1511856000"; d="scan'208";a="20818616"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48])
([10.237.220.48])
by FMSMGA003.fm.intel.com with ESMTP; 18 Jan 2018 09:31:00 -0800
To: Matan Azrad <matan@mellanox.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
References: <1516220357-13013-1-git-send-email-matan@mellanox.com>
<1516274834-19755-1-git-send-email-matan@mellanox.com>
<1516274834-19755-5-git-send-email-matan@mellanox.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <03662190-8477-b218-21f7-ecfb806b5997@intel.com>
Date: Thu, 18 Jan 2018 17:31:00 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <1516274834-19755-5-git-send-email-matan@mellanox.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v6 4/6] ethdev: adjust APIs removal error
report
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jan 2018 17:31:04 -0000
On 1/18/2018 11:27 AM, Matan Azrad wrote:
> rte_eth_dev_is_removed API was added to detect a device removal
> synchronously.
>
> When a device removal occurs during control command execution, many
> different errors can be reported to the user.
>
> Adjust all ethdev APIs error reports to return -EIO in case of device
> removal using rte_eth_dev_is_removed API.
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> lib/librte_ether/rte_ethdev.c | 192 +++++++++++++++++++++++++++---------------
> lib/librte_ether/rte_ethdev.h | 51 ++++++++++-
> 2 files changed, 170 insertions(+), 73 deletions(-)
>
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index c93cec1..7044159 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -338,6 +338,16 @@ struct rte_eth_dev *
> return -ENODEV;
> }
>
> +static int
> +eth_err(uint16_t port_id, int ret)
> +{
> + if (ret == 0)
> + return 0;
> + if (rte_eth_dev_is_removed(port_id))
> + return -EIO;
> + return ret;
> +}
> +
> /* attach the new device, then store port_id of the device */
> int
> rte_eth_dev_attach(const char *devargs, uint16_t *port_id)
> @@ -492,7 +502,8 @@ struct rte_eth_dev *
> return 0;
> }
>
> - return dev->dev_ops->rx_queue_start(dev, rx_queue_id);
> + return eth_err(port_id, dev->dev_ops->rx_queue_start(dev,
> + rx_queue_id));
>
> }
This patch updates *all* ethdev public APIs to add if device is removed check?
And each check goes to ethdev is_removed() dev_ops to ask if dev is removed.
These must be better way of doing this, am I missing something.
I definitely would like to see more comments for this patch.
Another question is what happens if device removed while or before dev_ops
called? There is no synchronizations in drivers for removal, right?
<...>