From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <qi.z.zhang@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id DFEB0DE0
 for <dev@dpdk.org>; Fri, 31 Mar 2017 02:57:53 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
 d=intel.com; i=@intel.com; q=dns/txt; s=intel;
 t=1490921874; x=1522457874;
 h=from:to:cc:subject:date:message-id:references:
 in-reply-to:content-transfer-encoding:mime-version;
 bh=jGrZAqflQivhQLG66WkOhwQqbPTO64CWAVaShVvOPhU=;
 b=JYTcKbbZie/5ZNPIbZC/IrlJbXg4z8cFo8OMdfJGKQGeLS1g0ZZZntuA
 lpa06t7vukWZlQ6FK+/1ZwrhoVjLzg==;
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 30 Mar 2017 17:57:52 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,249,1486454400"; d="scan'208";a="950011314"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
 by orsmga003.jf.intel.com with ESMTP; 30 Mar 2017 17:57:52 -0700
Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by
 FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 30 Mar 2017 17:57:52 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 30 Mar 2017 17:57:51 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.253]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.224]) with mapi id 14.03.0248.002;
 Fri, 31 Mar 2017 08:57:50 +0800
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2 2/3] eal: clean up interrupt handle
Thread-Index: AQHSlxzfqOGtNrztIkiTLlcGyUKjrqGtNDAAgAERHAA=
Date: Fri, 31 Mar 2017 00:57:50 +0000
Message-ID: <039ED4275CED7440929022BC67E7061153079E58@SHSMSX103.ccr.corp.intel.com>
References: <1487801822-30938-1-git-send-email-qi.z.zhang@intel.com>
 <20170307091928.57990-1-qi.z.zhang@intel.com>
 <20170307091928.57990-3-qi.z.zhang@intel.com> <4826709.YPY02QJpPJ@xps13>
In-Reply-To: <4826709.YPY02QJpPJ@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 2/3] eal: clean up interrupt handle
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Mar 2017 00:57:54 -0000



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, March 31, 2017 12:40 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v2 2/3] eal: clean up interrupt handle
>=20
> 2017-03-07 04:19, Qi Zhang:
> > The patch change the prototype of callback function
> > (rte_intr_callback_fn) by removing the unnecessary parameter.
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> >  drivers/net/bnxt/bnxt_irq.c                    |  3 +--
> >  drivers/net/e1000/em_ethdev.c                  |  8 +++-----
> >  drivers/net/e1000/igb_ethdev.c                 | 15 ++++++---------
> >  drivers/net/enic/enic_main.c                   |  3 +--
> >  drivers/net/fm10k/fm10k_ethdev.c               | 12 ++++--------
> >  drivers/net/i40e/i40e_ethdev.c                 |  8 +++-----
> >  drivers/net/i40e/i40e_ethdev_vf.c              |  5 ++---
> >  drivers/net/ixgbe/ixgbe_ethdev.c               | 14 +++++---------
> >  drivers/net/nfp/nfp_net.c                      |  6 ++----
> >  drivers/net/qede/qede_ethdev.c                 |  4 ++--
> >  drivers/net/sfc/sfc_intr.c                     | 10 ++++++----
> >  drivers/net/virtio/virtio_ethdev.c             |  5 ++---
> >  lib/librte_eal/common/include/rte_interrupts.h |  3 +--
> >  lib/librte_eal/linuxapp/eal/eal_alarm.c        |  5 ++---
> >  lib/librte_eal/linuxapp/eal/eal_interrupts.c   |  3 +--
> >  15 files changed, 41 insertions(+), 63 deletions(-)
>=20
> bnx2x must be updated.
> There is an error with bnx2x_interrupt_handler.

Will update
Thanks!

Qi