From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8CE803772 for ; Tue, 4 Apr 2017 14:41:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491309709; x=1522845709; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=SWGqd7My3aeNnbkzr6UQOHwnQed8cc1ZpFMIsIsPESY=; b=l2QZJclcUaVAq3j4LSMew6y8u1io4/f3ica/MkZmNpRoAJ5P+uEqCQmR KgPuhW7IHZ7xQFUoBxg2uIkpO7a3OA==; Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2017 05:41:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,275,1486454400"; d="scan'208";a="82704075" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 04 Apr 2017 05:41:48 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 4 Apr 2017 05:41:48 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by shsmsx102.ccr.corp.intel.com ([169.254.2.246]) with mapi id 14.03.0319.002; Tue, 4 Apr 2017 20:41:45 +0800 From: "Zhang, Qi Z" To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 0/2] clean up interrupt handle Thread-Index: AQHSqbzE7v1TwzK2jUueOzwVPpd5RaG0fl2AgACUKOA= Date: Tue, 4 Apr 2017 12:41:45 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153086A0B@SHSMSX103.ccr.corp.intel.com> References: <20170331020913.19004-1-qi.z.zhang@intel.com> <6430789.TYnjRxi5iG@xps13> In-Reply-To: <6430789.TYnjRxi5iG@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 0/2] clean up interrupt handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 12:41:50 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, April 4, 2017 6:13 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: Re: [PATCH v3 0/2] clean up interrupt handle >=20 > Hi, >=20 > 2017-03-30 22:09, Qi Zhang: > > It seems its not necessary to register an intr_handle for interrupt > > callback function. "void* cb_arg" shows enough when be used to pass > > the object that contain the information be required to handle the > > interrupt event( A typical way which is implemented by almost all > > driver is by passing a rte_ethdev instance). The patch change the > > prototype of rte_intr_callback_fn by removing the uncessary intr_handle > paramter. > > > > v3: > > - update bnx2x driver which is missed in v1,v2 > > > > v2: > > - seperate patch 1 in v1 into 2 patches. > > - correct some commit log. > > > > Qi Zhang (2): > > eal: clean up interrupt handle > > app/test: update test code >=20 > Several comments: >=20 > * You forgot to use --in-reply-to, so it is not convenient to check the h= istory. Will follow, thanks for your reminder. >=20 > * Please keep the the prior acked-by in your patches if there are. Will add that back >=20 > * There is another miss in this patch: >=20 > drivers/net/mlx5/mlx5_ethdev.c:1259:10: > fatal error: incompatible pointer types passing 'void (struct rte_intr_ha= ndle *, > void *)' > to parameter of type 'rte_intr_callback_fn' > (aka 'void (*)(void *)') [-Wincompatible-pointer-types] > mlx5_dev_interrupt_handler, After I turn on mlx5 driver and downloaded the missing mlx libraries, I saw= this issue. Will update. >=20 > * The second patch is clearly not up to date as the file > app/test/test_interrupts.c has moved. Will sync to latest code. Thanks Qi