From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3E6F32FDD for ; Tue, 4 Apr 2017 16:23:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491315829; x=1522851829; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=WT/zzdFX11bP8PvOM94u5C7175DJsXAg90dZZ+qetEE=; b=C5gvFZ719NoAg813kc7Vh7yhgXxQW+fi4ac8ZnArgEpiSQSqK5HAGxje ZN986EHTp/p2z50pjBtgRkxBh8nnSg==; Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2017 07:23:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,275,1486454400"; d="scan'208";a="1130761338" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 04 Apr 2017 07:23:45 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 4 Apr 2017 07:23:45 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 4 Apr 2017 07:23:45 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.193]) with mapi id 14.03.0319.002; Tue, 4 Apr 2017 22:23:43 +0800 From: "Zhang, Qi Z" To: Shahaf Shuler , "thomas.monjalon@6wind.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 2/2] eal: clean up interrupt handle Thread-Index: AQHSrUc6n/1nWNo5aEC1j76pUW6xsKG0tUiAgACKipA= Date: Tue, 4 Apr 2017 14:23:42 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153086AD2@SHSMSX103.ccr.corp.intel.com> References: <20170331020913.19004-1-qi.z.zhang@intel.com> <20170404212125.32114-1-qi.z.zhang@intel.com> <20170404212125.32114-3-qi.z.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/2] eal: clean up interrupt handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 14:23:49 -0000 > -----Original Message----- > From: Shahaf Shuler [mailto:shahafs@mellanox.com] > Sent: Tuesday, April 4, 2017 9:54 PM > To: Zhang, Qi Z ; thomas.monjalon@6wind.com > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 2/2] eal: clean up interrupt handle >=20 > Wednesday, April 5, 2017 12:21 AM, Qi Zhang: > > The patch change the prototype of callback function > > (rte_intr_callback_fn) by removing the unnecessary parameter. > > > > Signed-off-by: Qi Zhang > > --- > > > > v4: > > > > - Update mlx5 driver which is missed in v1, v2, v3. >=20 > Thanks for the update of mlx5. > The compilation is still failing for mlx4. the implementation there is mu= ch > similar to mlx5. OK, should not rely on compile option , now scan the code, this should be t= he last missing one:) Thanks. >=20 > > > > v3: > > > > - Update bnx2x driver which is missed in v1,v2 > > > > v2: > > > > - Seperate patch 1 of v1 into 2 patches.(part 2) > > > > drivers/net/bnx2x/bnx2x_ethdev.c | 5 +++-- > > drivers/net/bnxt/bnxt_irq.c | 3 +-- > > drivers/net/e1000/em_ethdev.c | 8 +++----- > > drivers/net/e1000/igb_ethdev.c | 15 ++++++--------- > > drivers/net/enic/enic_main.c | 3 +-- > > drivers/net/fm10k/fm10k_ethdev.c | 12 ++++-------- > > drivers/net/i40e/i40e_ethdev.c | 8 +++----- > > drivers/net/i40e/i40e_ethdev_vf.c | 5 ++--- > > drivers/net/ixgbe/ixgbe_ethdev.c | 14 +++++--------- > > drivers/net/mlx5/mlx5.h | 2 +- > > drivers/net/mlx5/mlx5_ethdev.c | 3 +-- > > drivers/net/nfp/nfp_net.c | 6 ++---- > > drivers/net/qede/qede_ethdev.c | 4 ++-- > > drivers/net/sfc/sfc_intr.c | 10 ++++++---- > > drivers/net/virtio/virtio_ethdev.c | 5 ++--- > > lib/librte_eal/common/include/rte_interrupts.h | 3 +-- > > lib/librte_eal/linuxapp/eal/eal_alarm.c | 5 ++--- > > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 3 +-- > > 18 files changed, 46 insertions(+), 68 deletions(-) >=20 > [...] >=20 > > @@ -119,12 +119,13 @@ bnx2x_interrupt_action(struct rte_eth_dev > *dev)