From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id C2281326C for ; Tue, 4 Apr 2017 16:58:31 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 04 Apr 2017 07:58:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,275,1486454400"; d="scan'208";a="841693891" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 04 Apr 2017 07:58:30 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 4 Apr 2017 07:58:30 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 4 Apr 2017 07:58:29 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by shsmsx102.ccr.corp.intel.com ([169.254.2.246]) with mapi id 14.03.0319.002; Tue, 4 Apr 2017 22:58:27 +0800 From: "Zhang, Qi Z" To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [PATCH v5 0/2] clean up interrupt handle Thread-Index: AQHSrVB3IgX/ZoZ2Q0iOy2w4KpTeRaG0xLuAgACHjiA= Date: Tue, 4 Apr 2017 14:58:26 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153086B30@SHSMSX103.ccr.corp.intel.com> References: <20170404212125.32114-1-qi.z.zhang@intel.com> <20170404222732.981-1-qi.z.zhang@intel.com> <8091532.IGg7nCNBxL@xps13> In-Reply-To: <8091532.IGg7nCNBxL@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 0/2] clean up interrupt handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 14:58:32 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, April 4, 2017 10:50 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: Re: [PATCH v5 0/2] clean up interrupt handle >=20 > 2017-04-05 06:27, Qi Zhang: > > It seems its not necessary to register an intr_handle for interrupt > > callback function. "void* cb_arg" shows enough when be used to pass > > the object that contain the information be required to handle the > > interrupt event( A typical way which is implemented by almost all > > driver is by passing a rte_ethdev instance). > > The patch change the prototype of rte_intr_callback_fn by removing the > > uncessary intr_handle paramter. > > > > v5: > > > > - Update mlx4 driver which is missed in previous version. > > > > v4: > > > > - Update mlx5 driver which is missed in v1, v2, v3. > > - Add back patch 1 of v2 to make this complete though it already be > applied. > > - Remove patch 3 which is not necessary with latest master. >=20 > Why have you removed patch 3? >=20 > There is this error now: >=20 > test/test/test_interrupts.c:217:4: fatal error: > incompatible pointer types passing 'void (struct rte_intr_handle *, void = *)' > to parameter of type 'rte_intr_callback_fn' (aka 'void (*)(void *)') > [-Wincompatible-pointer-types] > test_interrupt_callback, arg) >=3D 0) { >=20 Sorry, did not noticed the recent change "mk: do not build tests by default= ", I thought the related test code has been removed. Will Fix.