From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7B1E03005 for ; Wed, 12 Apr 2017 13:43:33 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2017 04:43:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,190,1488873600"; d="scan'208";a="247671998" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 12 Apr 2017 04:43:32 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 12 Apr 2017 04:43:32 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 12 Apr 2017 04:43:31 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.224]) with mapi id 14.03.0319.002; Wed, 12 Apr 2017 19:43:28 +0800 From: "Zhang, Qi Z" To: "Iremonger, Bernard" , "dev@dpdk.org" CC: "Xing, Beilei" , "Lu, Wenzhuo" , "Zhang, Qi" , "Iremonger, Bernard" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used Thread-Index: AQHSstSvIPBb38HHGEWbbagIeiwIzaHBmzcw Date: Wed, 12 Apr 2017 11:43:27 +0000 Message-ID: <039ED4275CED7440929022BC67E706115308B12A@SHSMSX103.ccr.corp.intel.com> References: <1491922880-18702-1-git-send-email-bernard.iremonger@intel.com> In-Reply-To: <1491922880-18702-1-git-send-email-bernard.iremonger@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Apr 2017 11:43:34 -0000 Hi Bernard: > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger > Sent: Tuesday, April 11, 2017 11:01 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Lu, Wenzhuo > ; Zhang, Qi ; Iremonger, > Bernard > Subject: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not us= ed >=20 > In rx vector mode, the QinQ VLAN tag is not stripped. > When hw_vlan_extend is set for QinQ ensure that rx vector mode is not > selected. >=20 > Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from vector > driver") Why fixes? I didn't see above commit change rx callback function if hw_vlan= _extend =3D=3D 1 >=20 > Signed-off-by: Bernard Iremonger > --- > drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h > b/drivers/net/i40e/i40e_rxtx_vec_common.h > index 952fd4b63..692096684 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h > @@ -234,6 +234,10 @@ > i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev) > if (rxmode->header_split =3D=3D 1) > return -1; >=20 > + /* no QinQ support */ > + if (rxmode->hw_vlan_extend =3D=3D 1) > + return -1; > + > return 0; > #else > RTE_SET_USED(dev); > -- > 2.11.0