From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id EF8E937A2 for ; Wed, 12 Apr 2017 14:42:28 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP; 12 Apr 2017 05:42:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,190,1488873600"; d="scan'208";a="1154813096" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 12 Apr 2017 05:42:22 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 12 Apr 2017 05:42:21 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.217]) with mapi id 14.03.0319.002; Wed, 12 Apr 2017 20:42:20 +0800 From: "Zhang, Qi Z" To: "Iremonger, Bernard" , "dev@dpdk.org" CC: "Xing, Beilei" , "Lu, Wenzhuo" , "Zhang, Qi" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used Thread-Index: AQHSstSvIPBb38HHGEWbbagIeiwIzaHBmzcw//+KIoCAAIc0wA== Date: Wed, 12 Apr 2017 12:42:19 +0000 Message-ID: <039ED4275CED7440929022BC67E706115308B186@SHSMSX103.ccr.corp.intel.com> References: <1491922880-18702-1-git-send-email-bernard.iremonger@intel.com> <039ED4275CED7440929022BC67E706115308B12A@SHSMSX103.ccr.corp.intel.com> <8CEF83825BEC744B83065625E567D7C224D52F48@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C224D52F48@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Apr 2017 12:42:29 -0000 > -----Original Message----- > From: Iremonger, Bernard > Sent: Wednesday, April 12, 2017 8:30 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Xing, Beilei ; Lu, Wenzhuo > ; Zhang, Qi > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is no= t used >=20 > Hi Qi, >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Wednesday, April 12, 2017 12:43 PM > > To: Iremonger, Bernard ; dev@dpdk.org > > Cc: Xing, Beilei ; Lu, Wenzhuo > > ; Zhang, Qi ; Iremonger, > > Bernard > > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is > > not used > > > > Hi Bernard: > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard > > Iremonger > > > Sent: Tuesday, April 11, 2017 11:01 PM > > > To: dev@dpdk.org > > > Cc: Xing, Beilei ; Lu, Wenzhuo > > > ; Zhang, Qi ; Iremonger, > > > Bernard > > > Subject: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is > > > not used > > > > > > In rx vector mode, the QinQ VLAN tag is not stripped. > > > When hw_vlan_extend is set for QinQ ensure that rx vector mode is > > > not selected. > > > > > > Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from > > > vector > > > driver") > > > > Why fixes? I didn't see above commit change rx callback function if > > hw_vlan_extend =3D=3D 1 >=20 > Some of the QinQ functionality was introduced in 17.02, this functionalit= y also > has the same issue. > So I added a fixes line. If you think this patch is a fix, you need to find the commit that introduc= e this issue The commit ca74903b75cf is not the root cause of the issue, it just move th= e code from=20 I40e_rxtx_vec.c to i40e_rxtx_vec_common.h Regards Qi =20