From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E1CA77CCA for ; Thu, 1 Jun 2017 03:45:00 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 31 May 2017 18:44:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,277,1493708400"; d="scan'208";a="975359005" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 31 May 2017 18:44:59 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 31 May 2017 18:44:59 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002; Thu, 1 Jun 2017 09:44:57 +0800 From: "Zhang, Qi Z" To: "gaetan.rivet@6wind.com" , "dev@dpdk.org" CC: Adrien Mazarguil , "Mcnamara, John" Thread-Topic: [dpdk-dev] [PATCH] ethdev: add roughly match pattern Thread-Index: AQHS1Ffznm40/YbRSk20g7xhifkbIKIMVrgAgAE/6QCAAbEtkA== Date: Thu, 1 Jun 2017 01:44:56 +0000 Message-ID: <039ED4275CED7440929022BC67E70611530A69E6@SHSMSX103.ccr.corp.intel.com> References: <1495582134-13665-1-git-send-email-qi.z.zhang@intel.com> <20170530124630.GA1758@6wind.com> <20170531075129.GP14914@bidouze.vm.6wind.com> In-Reply-To: <20170531075129.GP14914@bidouze.vm.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ethdev: add roughly match pattern X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 01:45:01 -0000 > -----Original Message----- > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > Sent: Wednesday, May 31, 2017 3:52 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Adrien Mazarguil ; Mcnamara, John > > Subject: Re: [dpdk-dev] [PATCH] ethdev: add roughly match pattern >=20 > On Tue, May 30, 2017 at 02:46:30PM +0200, Adrien Mazarguil wrote: > >Hi Zhang, > > > >You should cram "flow API" somewhere in the title of such commits. > > > >On Tue, May 23, 2017 at 07:28:54PM -0400, Qi Zhang wrote: > >> Add new meta pattern item RTE_FLOW_TYPE_ITEM_ROUGHLY. > >> > >> This is for device that support no-perfect match option. > >> Usually a no-perfect match is fast but the cost is accuracy. > >> i.e. Signature Match only match pattern's hash value, but it is > >> possible two different patterns have the same hash value. > >> > >> Matching accuracy level can be configure by subfield threshold. > >> Driver can divide the range of threshold and map to different > >> accuracy levels that device support. > >> > >> Signed-off-by: Qi Zhang > > > >While I really like the "roughly" pattern item name since it perfectly > >describes its intended purpose in my opinion, perhaps some may not find > >this name appropriate. I would like to hear other people's opinion on > >the matter and not be the only one to ack this patch. >=20 > "no-perfect" has been used a few times in the documentation. How about > "IMPERFECT" as item name? >=20 "Imperfect" looks better for me,=20 If no other objection, I will use this in V2. Thanks Qi > -- > Ga=EBtan Rivet > 6WIND