From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 885DB374C for ; Thu, 1 Jun 2017 08:14:37 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 May 2017 23:14:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,278,1493708400"; d="scan'208";a="268821400" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 31 May 2017 23:14:35 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 31 May 2017 23:14:36 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 31 May 2017 23:14:35 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002; Thu, 1 Jun 2017 14:14:33 +0800 From: "Zhang, Qi Z" To: "Lu, Wenzhuo" , "Zhang, Helin" CC: "dev@dpdk.org" Thread-Topic: [PATCH 2/3] net/ixgbe: enable signature match for consistent API Thread-Index: AQHS1pU8XKkS6smAcUewMCxUcx2+zqIPAp4AgACG8rD//39xgIAAhkwQ Date: Thu, 1 Jun 2017 06:14:33 +0000 Message-ID: <039ED4275CED7440929022BC67E70611530A6BA6@SHSMSX103.ccr.corp.intel.com> References: <1495828350-10259-1-git-send-email-qi.z.zhang@intel.com> <1495828350-10259-3-git-send-email-qi.z.zhang@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B5C9A32@shsmsx102.ccr.corp.intel.com> <039ED4275CED7440929022BC67E70611530A6B58@SHSMSX103.ccr.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B5C9A6A@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B5C9A6A@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: enable signature match for consistent API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 06:14:38 -0000 > -----Original Message----- > From: Lu, Wenzhuo > Sent: Thursday, June 1, 2017 2:13 PM > To: Zhang, Qi Z ; Zhang, Helin > > Cc: dev@dpdk.org > Subject: RE: [PATCH 2/3] net/ixgbe: enable signature match for consistent > API >=20 > Hi Qi, >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Thursday, June 1, 2017 1:56 PM > > To: Lu, Wenzhuo; Zhang, Helin > > Cc: dev@dpdk.org > > Subject: RE: [PATCH 2/3] net/ixgbe: enable signature match for > > consistent API > > > > > > > > > -----Original Message----- > > > From: Lu, Wenzhuo > > > Sent: Thursday, June 1, 2017 1:50 PM > > > To: Zhang, Qi Z ; Zhang, Helin > > > > > > Cc: dev@dpdk.org > > > Subject: RE: [PATCH 2/3] net/ixgbe: enable signature match for > > > consistent API > > > > > > Hi Qi, > > > > > > > -----Original Message----- > > > > From: Zhang, Qi Z > > > > Sent: Saturday, May 27, 2017 3:52 AM > > > > To: Zhang, Helin; Lu, Wenzhuo > > > > Cc: dev@dpdk.org; Zhang, Qi Z > > > > Subject: [PATCH 2/3] net/ixgbe: enable signature match for > > > > consistent API > > > > > > > > Enable signature match for rte_flow API. > > > > RTE_FLOW_ITEM_TYPE_ROUGHLY specify a signature match. > > > > > > > > Signed-off-by: Qi Zhang > > > Acked-by: Wenzhuo Lu > > > > > > Now I understand why you want to change the macro to the function in > > > the first patch. :) > > > > OK, I can merge the 2 patches into 1 in v2, if you think it's not > > necessary to separate. > It's better to have these 2 patches. Adding more info of the purpose in t= he > commit log, like "removing the index ...", can make it easier to understa= nd. :) OK, that make sense. >=20 > > > > Thanks > > Qi