From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5F8955688 for ; Thu, 1 Jun 2017 08:19:41 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 May 2017 23:19:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,278,1493708400"; d="scan'208";a="1136821853" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 31 May 2017 23:19:40 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 31 May 2017 23:19:39 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 31 May 2017 23:19:39 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002; Thu, 1 Jun 2017 14:19:36 +0800 From: "Zhang, Qi Z" To: "Lu, Wenzhuo" , "Zhang, Helin" CC: "dev@dpdk.org" Thread-Topic: [PATCH 3/3] net/ixgbe: enable IPv6 for consistent API Thread-Index: AQHS1pU9n1u3wwVig0u766UpMXFxQqIPCcKAgACGzYA= Date: Thu, 1 Jun 2017 06:19:35 +0000 Message-ID: <039ED4275CED7440929022BC67E70611530A6BBF@SHSMSX103.ccr.corp.intel.com> References: <1495828350-10259-1-git-send-email-qi.z.zhang@intel.com> <1495828350-10259-4-git-send-email-qi.z.zhang@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B5C9A96@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B5C9A96@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] net/ixgbe: enable IPv6 for consistent API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 06:19:41 -0000 > -----Original Message----- > From: Lu, Wenzhuo > Sent: Thursday, June 1, 2017 2:16 PM > To: Zhang, Qi Z ; Zhang, Helin > > Cc: dev@dpdk.org > Subject: RE: [PATCH 3/3] net/ixgbe: enable IPv6 for consistent API >=20 > Hi Qi, >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Saturday, May 27, 2017 3:53 AM > > To: Zhang, Helin; Lu, Wenzhuo > > Cc: dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH 3/3] net/ixgbe: enable IPv6 for consistent API > > > > Enable IPv6 support with rte_flow API. > > Only support Sigature Match. > > > > Signed-off-by: Qi Zhang > > --- > > drivers/net/ixgbe/ixgbe_flow.c | 112 > > ++++++++++++++++++++++++++++++++++++++--- > > 1 file changed, 104 insertions(+), 8 deletions(-) >=20 > > /* Get the TCP info. */ > > if (item->type =3D=3D RTE_FLOW_ITEM_TYPE_TCP) { > > /** > > * Set the flow type even if there's no content > > * as we must have a flow type. > > */ > > - rule->ixgbe_fdir.formatted.flow_type =3D > > + rule->ixgbe_fdir.formatted.flow_type |=3D > > IXGBE_ATR_FLOW_TYPE_TCPV4; > This macro is misleading, better change it to IXGBE_ATR_L4TYPE_TCP. >=20 > > /*Not supported last point for range*/ > > if (item->last) { > > @@ -1715,7 +1811,7 @@ ixgbe_parse_fdir_filter_normal(const struct > > rte_flow_attr *attr, > > * Set the flow type even if there's no content > > * as we must have a flow type. > > */ > > - rule->ixgbe_fdir.formatted.flow_type =3D > > + rule->ixgbe_fdir.formatted.flow_type |=3D > > IXGBE_ATR_FLOW_TYPE_UDPV4; > IXGBE_ATR_L4TYPE_UDP is better. >=20 > > /*Not supported last point for range*/ > > if (item->last) { > > @@ -1775,7 +1871,7 @@ ixgbe_parse_fdir_filter_normal(const struct > > rte_flow_attr *attr, > > * Set the flow type even if there's no content > > * as we must have a flow type. > > */ > > - rule->ixgbe_fdir.formatted.flow_type =3D > > + rule->ixgbe_fdir.formatted.flow_type |=3D > > IXGBE_ATR_FLOW_TYPE_SCTPV4; > IXGBE_ATR_L4TYPE_SCTP is better. >=20 > > /*Not supported last point for range*/ > > if (item->last) { > > -- > > 2.7.4 Yes, should use the macro but not enum here. Will change in v2 Thanks Qi