From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 206C15688 for ; Tue, 13 Jun 2017 08:03:23 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2017 23:03:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,336,1493708400"; d="scan'208";a="114157200" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 12 Jun 2017 23:03:22 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Jun 2017 23:03:22 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Jun 2017 23:03:22 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002; Tue, 13 Jun 2017 14:03:19 +0800 From: "Zhang, Qi Z" To: Adrien Mazarguil , Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] ethdev: add fuzzy match pattern Thread-Index: AQHS4BgiLJYm2EneEUy+oUjn9onU7aIaCM8AgAbU04CAAXVgsA== Date: Tue, 13 Jun 2017 06:03:19 +0000 Message-ID: <039ED4275CED7440929022BC67E70611530AA37A@SHSMSX103.ccr.corp.intel.com> References: <1495582134-13665-1-git-send-email-qi.z.zhang@intel.com> <1496874080-35086-1-git-send-email-qi.z.zhang@intel.com> <2304112.MuvLPJetXV@xps> <20170612153841.GE1758@6wind.com> In-Reply-To: <20170612153841.GE1758@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add fuzzy match pattern X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jun 2017 06:03:24 -0000 > -----Original Message----- > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > Sent: Monday, June 12, 2017 11:39 PM > To: Thomas Monjalon > Cc: Zhang, Qi Z ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add fuzzy match pattern >=20 > On Thu, Jun 08, 2017 at 09:19:24AM +0200, Thomas Monjalon wrote: > > Hi, > > > > 08/06/2017 00:21, Qi Zhang: > > > Add new meta pattern item RTE_FLOW_TYPE_ITEM_FUZZY. > > > > I disagree about fuzzy wording, because fuzzy is something different I > > think. >=20 > At least it's a generic term, unrelated PMDs could likewise implement > another kind of fuzzy matching for performance reasons (for applications > that really care more about performance than accuracy). The fact this > particular implementation is built on top of something that is internally > known as signature hash should not be relevant. >=20 > > > This is for device that support fuzzy match option. > > > Usually a fuzzy match is fast but the cost is accuracy. > > > i.e. Signature Match only match pattern's hash value, but it is > > > possible two different patterns have the same hash value. > > > > You have described it yourself here: it matches a hash of the signature= . > > Why not using "hash" as wording? >=20 > While "hash" would be also correct, in my opinion it would restrict this > pattern item to Intel adapters (ixgbe) with the ability to actually perfo= rm a > hash on patterns and use the resulting value to imperfectly match traffic= . > This excludes other implementations with similar unpredictable results. >=20 > Also a threshold notion is necessary as far as I understand, the signatur= e > mode has several levels. The higher, the fuzzier it gets. This behavior i= s > difficult to translate to something generic named "hash", as one would ha= ve > to describe how the hash is computed and packets matched according to > that value, which really is ixgbe-specific at the moment. >=20 > > > Matching accuracy level can be configure by subfield threshold. > > > Driver can divide the range of threshold and map to different > > > accuracy levels that device support. > > > > > > Signed-off-by: Qi Zhang >=20 > Qi, many of my other comments about v1 still stand, please check my > previous reply in any case. Sorry, seems I skipped that important mail by mistake, just find it, thanks= for all the comments.=20 >=20 > -- > Adrien Mazarguil > 6WIND