From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 807B14C8C for ; Thu, 1 Mar 2018 02:51:13 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2018 17:51:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,407,1515484800"; d="scan'208";a="34974161" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 28 Feb 2018 17:51:11 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Feb 2018 17:51:11 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Feb 2018 17:51:10 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.253]) with mapi id 14.03.0319.002; Thu, 1 Mar 2018 09:51:09 +0800 From: "Zhang, Qi Z" To: Stephen Hemminger CC: "dev@dpdk.org" , "Karlsson, Magnus" , "Topel, Bjorn" Thread-Topic: [dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver Thread-Index: AQHTsO3E9LVRj1M4T06SuH3goBKu0qO6mhlg Date: Thu, 1 Mar 2018 01:51:08 +0000 Message-ID: <039ED4275CED7440929022BC67E706115315D3B2@SHSMSX103.ccr.corp.intel.com> References: <20180227093306.23854-1-qi.z.zhang@intel.com> <20180227093306.23854-2-qi.z.zhang@intel.com> <20180228154217.4aff5095@xeon-e3> In-Reply-To: <20180228154217.4aff5095@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2018 01:51:14 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Thursday, March 1, 2018 7:42 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; magnus.karlsson@intei.com; Topel, Bjorn > > Subject: Re: [dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver >=20 > On Tue, 27 Feb 2018 17:33:00 +0800 > Qi Zhang wrote: >=20 > > struct pmd_internals { > > + int sfd; > > + int if_index; > > + char if_name[0x100]; >=20 > why not IFNAMSIZ? >=20 > > + struct ether_addr eth_addr; > > + struct xdp_queue rx; > > + struct xdp_queue tx; > > + struct xdp_umem *umem; > > + struct rte_mempool *mb_pool; > > + > > + unsigned long rx_pkts; > > + unsigned long rx_bytes; > > + unsigned long rx_dropped; > > + > > + unsigned long tx_pkts; > > + unsigned long err_pkts; > > + unsigned long tx_bytes; >=20 > why not per-queue stats? per-port stats are expensive multi-queue is not supported in this implementation, but will be considered= . Regards Qi >=20 > > + uint16_t port_id; > > + uint16_t queue_idx; > > + int ring_size; > > + struct rte_ring *buf_ring; > > +};