From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id BD9457CBA for ; Fri, 16 Mar 2018 07:25:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2018 23:25:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,313,1517904000"; d="scan'208";a="37923800" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 15 Mar 2018 23:25:28 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 15 Mar 2018 23:25:28 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 15 Mar 2018 23:25:28 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by shsmsx102.ccr.corp.intel.com ([169.254.2.80]) with mapi id 14.03.0319.002; Fri, 16 Mar 2018 14:25:26 +0800 From: "Zhang, Qi Z" To: "Xu, Rosen" , "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] drivers/net/i40e/i40e_ethdev_vf.c: fix missing promiscuous disable at device stop Thread-Index: AQHTvEH3lVV1xxB1iUWBysqXgl7OE6PSY/mA Date: Fri, 16 Mar 2018 06:25:26 +0000 Message-ID: <039ED4275CED7440929022BC67E706115316E52F@SHSMSX103.ccr.corp.intel.com> References: <1521107140-68349-1-git-send-email-rosen.xu@intel.com> In-Reply-To: <1521107140-68349-1-git-send-email-rosen.xu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] drivers/net/i40e/i40e_ethdev_vf.c: fix missing promiscuous disable at device stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 06:25:30 -0000 Hi Rosen: > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rosen Xu > Sent: Thursday, March 15, 2018 5:46 PM > To: Xing, Beilei > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] drivers/net/i40e/i40e_ethdev_vf.c: fix > missing promiscuous disable at device stop >=20 > In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit does= n't > disable promiscuous mode, this will cause vlan filter set by Kernel Drive= r will > not take effect. >=20 > This patch will fix it, add promiscuous disable at device stop. >=20 > Signed-off-by: Rosen Xu > --- > drivers/net/i40e/i40e_ethdev_vf.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index fd003fe..f395b02 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -2051,6 +2051,8 @@ static int eth_i40evf_pci_remove(struct > rte_pci_device *pci_dev) >=20 > if (hw->adapter_stopped =3D=3D 1) > return; > + i40evf_dev_promiscuous_disable(dev); > + i40evf_dev_allmulticast_disable(dev); Device's promiscuous mode is not expected to be changed in a dev_start/dev_= stop cycle Application need to call rte_eth_promiscuous_disable and i40evf_dev_allmult= icast_disable to change it explicitly. Regards Qi > i40evf_stop_queues(dev); > i40evf_disable_queues_intr(dev); > i40e_dev_clear_queues(dev); > -- > 1.8.3.1