From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A28AE7CB6 for ; Wed, 28 Mar 2018 05:37:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2018 20:36:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,369,1517904000"; d="scan'208";a="28178179" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 27 Mar 2018 20:36:58 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 27 Mar 2018 20:36:58 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 27 Mar 2018 20:36:58 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.166]) with mapi id 14.03.0319.002; Wed, 28 Mar 2018 11:36:56 +0800 From: "Zhang, Qi Z" To: "Jankowski, Konrad" , "Dai, Wei" , "Xing, Beilei" , "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [PATCH] net/i40evf: regression fix - reenable interrupts in handler Thread-Index: AQHTpcGfwtQQeezB/k+EW7yM0MRjU6PlP5dw Date: Wed, 28 Mar 2018 03:36:55 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153175394@SHSMSX103.ccr.corp.intel.com> References: <1518633151-29118-1-git-send-email-konrad.jankowski@intel.com> In-Reply-To: <1518633151-29118-1-git-send-email-konrad.jankowski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40evf: regression fix - reenable interrupts in handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 03:37:03 -0000 Hi Jankowski: > -----Original Message----- > From: Jankowski, KonradX > Sent: Thursday, February 15, 2018 2:33 AM > To: Dai, Wei ; Xing, Beilei ; Z= hang, > Qi Z ; Wu, Jingjing ; > dev@dpdk.org > Cc: Jankowski, KonradX > Subject: [PATCH] net/i40evf: regression fix - reenable interrupts in hand= ler >=20 > Commit 66b8304f removed the rte_intr_enable() call from > i40evf_dev_interrupt_handler() as a "bonus". On one of my systems this > causes the AdminQ messages to stop beeing delivered to the VF. This resul= ts > in unability to initialize and use the port. With this patch it works aga= in. >=20 > System in question: > Wind River OVP6 running kernel 3.10.58-ovp-rt58-WR6.0.0.13_preempt-rt >=20 > Signed-off-by: Konrad Jankowski > --- > drivers/net/i40e/i40e_ethdev_vf.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index fd003fe..b927a35 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -1404,6 +1404,7 @@ i40evf_dev_interrupt_handler(void *param) >=20 > done: > i40evf_enable_irq0(hw); > + rte_intr_enable(dev->intr_handle);' Would you explain more about why the patch fix the issue? Usually we will not accept a fix just because it work but not understand th= e root cause. Regards Qi > } >=20 > static int > -- > 2.5.5