Re: [dpdk-dev] [PATCH v4 0/4] net/ixgbe: convert to new offloads API

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Dai
> Sent: Thursday, March 22, 2018 11:41 AM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>
> Subject: [dpdk-dev] [PATCH v4 0/4] net/ixgbe: convert to new offloads API
> 
> This patch set adds support of per queue VLAN strip offloading in ixgbe PF and
> VF.
> This patch support new offloads API in ixgbe PF and VF.
> 
> ---
> v4: don't support header spliting any more
> 
> v3: Rx header spliting capability is only enabled in
>     #ifdef RTE_HEADER_SPLIT_ENABLE.
>     Tx vector tranmit function only work without any Tx offloads.
> 
> v2: improve error checking
> 
> Wei Dai (4):
>   net/ixgbe: support VLAN strip per queue offloading in PF
>   net/ixgbe: support VLAN strip per queue offloading in VF
>   net/ixgbe: convert to new Rx offloads API
>   net/ixgbe: convert to new Tx offloads API
> 
>  drivers/net/ixgbe/ixgbe_ethdev.c          | 264
> ++++++++++++++--------------
>  drivers/net/ixgbe/ixgbe_ethdev.h          |   4 +-
>  drivers/net/ixgbe/ixgbe_ipsec.c           |  13 +-
>  drivers/net/ixgbe/ixgbe_pf.c              |   5 +-
>  drivers/net/ixgbe/ixgbe_rxtx.c            | 275
> +++++++++++++++++++++++-------
>  drivers/net/ixgbe/ixgbe_rxtx.h            |   7 +
>  drivers/net/ixgbe/ixgbe_rxtx_vec_common.h |   5 -
>  drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c   |   2 +-
>  8 files changed, 359 insertions(+), 216 deletions(-)
> 
> --
> 2.9.5

It's better to only enable per queue vlan-strip without convert to new offload in patch 1,2
then convert all to new offload in patch 3,4
But still ok for me.

Acked-by: Qi Zhang <qi.z.zhang@intel.com>