* [dpdk-dev] [PATCH] net/i40e: fix flow RSS tci using error
@ 2018-04-03 6:09 Wei Zhao
2018-04-03 14:03 ` Zhang, Qi Z
0 siblings, 1 reply; 4+ messages in thread
From: Wei Zhao @ 2018-04-03 6:09 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, Wei Zhao
Vlan tci configuration from testpmd is store in big endian, so it
need to be change to little endian before using.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
---
drivers/net/i40e/i40e_flow.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index fa562d3..8d0a36b 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -4151,7 +4151,8 @@ i40e_flow_parse_rss_pattern(__rte_unused struct rte_eth_dev *dev,
if (vlan_mask->tci ==
rte_cpu_to_be_16(I40E_TCI_MASK)) {
info->region[0].user_priority[0] =
- (vlan_spec->tci >> 13) & 0x7;
+ (rte_be_to_cpu_16(
+ vlan_spec->tci) >> 13) & 0x7;
info->region[0].user_priority_num = 1;
info->queue_region_number = 1;
*action_flag = 0;
--
2.7.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS tci using error
2018-04-03 6:09 [dpdk-dev] [PATCH] net/i40e: fix flow RSS tci using error Wei Zhao
@ 2018-04-03 14:03 ` Zhang, Qi Z
2018-04-03 15:17 ` Zhang, Helin
2018-04-04 1:29 ` Zhao1, Wei
0 siblings, 2 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2018-04-03 14:03 UTC (permalink / raw)
To: Zhao1, Wei, dev
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Tuesday, April 3, 2018 2:10 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: fix flow RSS tci using error
>
> Vlan tci configuration from testpmd is store in big endian, so it need to be
> change to little endian before using.
>
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Please don't forget to Cc: stable@dpdk.org, if you fix an issue for previous release.
Regards
Qi
> ---
> drivers/net/i40e/i40e_flow.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> fa562d3..8d0a36b 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -4151,7 +4151,8 @@ i40e_flow_parse_rss_pattern(__rte_unused struct
> rte_eth_dev *dev,
> if (vlan_mask->tci ==
> rte_cpu_to_be_16(I40E_TCI_MASK)) {
> info->region[0].user_priority[0] =
> - (vlan_spec->tci >> 13) & 0x7;
> + (rte_be_to_cpu_16(
> + vlan_spec->tci) >> 13) & 0x7;
> info->region[0].user_priority_num = 1;
> info->queue_region_number = 1;
> *action_flag = 0;
> --
> 2.7.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS tci using error
2018-04-03 14:03 ` Zhang, Qi Z
@ 2018-04-03 15:17 ` Zhang, Helin
2018-04-04 1:29 ` Zhao1, Wei
1 sibling, 0 replies; 4+ messages in thread
From: Zhang, Helin @ 2018-04-03 15:17 UTC (permalink / raw)
To: Zhang, Qi Z, Zhao1, Wei, dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Tuesday, April 3, 2018 10:03 PM
> To: Zhao1, Wei; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS tci using error
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Tuesday, April 3, 2018 2:10 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH] net/i40e: fix flow RSS tci using error
> >
> > Vlan tci configuration from testpmd is store in big endian, so it need
> > to be change to little endian before using.
> >
> > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Tested-by: Peng Yuan <yuan.peng@intel.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!
/Helin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS tci using error
2018-04-03 14:03 ` Zhang, Qi Z
2018-04-03 15:17 ` Zhang, Helin
@ 2018-04-04 1:29 ` Zhao1, Wei
1 sibling, 0 replies; 4+ messages in thread
From: Zhao1, Wei @ 2018-04-04 1:29 UTC (permalink / raw)
To: Zhang, Qi Z, dev
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Tuesday, April 3, 2018 10:03 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH] net/i40e: fix flow RSS tci using error
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Tuesday, April 3, 2018 2:10 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH] net/i40e: fix flow RSS tci using error
> >
> > Vlan tci configuration from testpmd is store in big endian, so it need
> > to be change to little endian before using.
> >
> > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Tested-by: Peng Yuan <yuan.peng@intel.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Please don't forget to Cc: stable@dpdk.org, if you fix an issue for previous
> release.
Ok.
>
> Regards
> Qi
>
> > ---
> > drivers/net/i40e/i40e_flow.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_flow.c
> > b/drivers/net/i40e/i40e_flow.c index fa562d3..8d0a36b 100644
> > --- a/drivers/net/i40e/i40e_flow.c
> > +++ b/drivers/net/i40e/i40e_flow.c
> > @@ -4151,7 +4151,8 @@ i40e_flow_parse_rss_pattern(__rte_unused
> struct
> > rte_eth_dev *dev,
> > if (vlan_mask->tci ==
> > rte_cpu_to_be_16(I40E_TCI_MASK))
> {
> > info->region[0].user_priority[0] =
> > - (vlan_spec->tci >> 13) & 0x7;
> > + (rte_be_to_cpu_16(
> > + vlan_spec->tci) >> 13) & 0x7;
> > info->region[0].user_priority_num =
> 1;
> > info->queue_region_number = 1;
> > *action_flag = 0;
> > --
> > 2.7.5
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-04 1:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-03 6:09 [dpdk-dev] [PATCH] net/i40e: fix flow RSS tci using error Wei Zhao
2018-04-03 14:03 ` Zhang, Qi Z
2018-04-03 15:17 ` Zhang, Helin
2018-04-04 1:29 ` Zhao1, Wei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).