From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id C97701BB47; Wed, 4 Apr 2018 05:59:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2018 20:59:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,404,1517904000"; d="scan'208";a="34087997" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 03 Apr 2018 20:59:19 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 3 Apr 2018 20:59:16 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 3 Apr 2018 20:59:16 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.241]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.92]) with mapi id 14.03.0319.002; Wed, 4 Apr 2018 11:59:07 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/i40e: add flow RSS queue index check Thread-Index: AQHTy8ZD2u3JkM+yHUyQaQRRZ4RCAaPv+PJA Date: Wed, 4 Apr 2018 03:59:06 +0000 Message-ID: <039ED4275CED7440929022BC67E706115318212C@SHSMSX103.ccr.corp.intel.com> References: <1522811927-46772-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1522811927-46772-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: add flow RSS queue index check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 03:59:21 -0000 > -----Original Message----- > From: Zhao1, Wei > Sent: Wednesday, April 4, 2018 11:19 AM > To: dev@dpdk.org; stable@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH] net/i40e: add flow RSS queue index check >=20 > There need a queue index check for RSS queue region in order to aviod err= or > from configuration. >=20 > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") > Signed-off-by: Wei Zhao > Tested-by: Peng Yuan Please add Cc: stable@dpdk.org here. > --- > drivers/net/i40e/i40e_flow.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > f3e8c5f..4e86ecb 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4249,6 +4249,20 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > *dev, > return -rte_errno; > } >=20 > + for (i =3D 0; i < rss->num; i++) { > + for (j =3D 0; j < rss_info->num; j++) { > + if (rss->queue[i] =3D=3D rss_info->queue[j]) > + break; > + } > + if (j =3D=3D rss_info->num) { > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ACTION, > + act, > + "no valid queues"); > + return -rte_errno; > + } > + } Is it necessary to add this check inside the big loop ? Btw, the function of i40e_flow_parse_rss_action looks too big and without e= nough comment It's better to use sub-function or add some comment before each code block= =20 to make it more readable. Regards Qi =20 > + > for (i =3D 0; i < info->queue_region_number; i++) { > if (info->region[i].queue_num =3D=3D rss->num && > info->region[i].queue_start_index =3D=3D > -- > 2.7.5