From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 84B541C186; Wed, 4 Apr 2018 15:25:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2018 06:25:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,406,1517904000"; d="scan'208";a="47891160" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 04 Apr 2018 06:25:43 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 4 Apr 2018 06:25:42 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.241]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.43]) with mapi id 14.03.0319.002; Wed, 4 Apr 2018 21:25:41 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v4] net/i40e: add flow RSS queue index check Thread-Index: AQHTy+5mvyG1gxgn/k6N5K2Tj5D4vaPwly6Q Date: Wed, 4 Apr 2018 13:25:40 +0000 Message-ID: <039ED4275CED7440929022BC67E706115318273D@SHSMSX103.ccr.corp.intel.com> References: <1522818387-63961-1-git-send-email-wei.zhao1@intel.com> <1522829163-63066-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1522829163-63066-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: add flow RSS queue index check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 13:25:46 -0000 > -----Original Message----- > From: Zhao1, Wei > Sent: Wednesday, April 4, 2018 4:06 PM > To: dev@dpdk.org; stable@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH v4] net/i40e: add flow RSS queue index check tile start with fix. >=20 > There need a queue index check for RSS queue region in order to aviod err= or > from configuration. >=20 > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") > Signed-off-by: Wei Zhao > Tested-by: Peng Yuan Should be Tested-by: Yuan Peng Acked-by: Qi Zhang >=20 > --- >=20 > Changes in v2: >=20 > move check code out from the big loop. >=20 > change in v3: >=20 > delete unnecessary dash in comment. >=20 > change in v4: >=20 > add more parameters check code. > --- > drivers/net/i40e/i40e_flow.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > f3e8c5f..f4d08bb 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4216,6 +4216,32 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > *dev, > } > } >=20 > + if (conf_info->queue_region_number) { > + for (i =3D 0; i < rss->num; i++) { > + for (j =3D 0; j < rss_info->num; j++) { > + if (rss->queue[i] =3D=3D rss_info->queue[j]) > + break; > + } > + if (j =3D=3D rss_info->num) { > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ACTION, > + act, > + "no valid queues"); > + return -rte_errno; > + } > + } > + > + for (i =3D 0; i < rss->num - 1; i++) { > + if (rss->queue[i + 1] !=3D rss->queue[i] + 1) { > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ACTION, > + act, > + "no valid queues"); > + return -rte_errno; > + } > + } > + } > + > for (n =3D 0; n < conf_info->queue_region_number; n++) { > if (conf_info->region[n].user_priority_num || > conf_info->region[n].flowtype_num) { > -- > 2.7.5