From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C992B1BB66 for ; Fri, 13 Apr 2018 04:38:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2018 19:38:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,444,1517904000"; d="scan'208";a="47510671" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 12 Apr 2018 19:38:32 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 12 Apr 2018 19:38:32 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 12 Apr 2018 19:38:32 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.151]) by shsmsx102.ccr.corp.intel.com ([169.254.2.184]) with mapi id 14.03.0319.002; Fri, 13 Apr 2018 10:37:55 +0800 From: "Zhang, Qi Z" To: Shweta Choudaha , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Zhang, Helin" , "Yigit, Ferruh" , "shweta.choudaha@att.com" Thread-Topic: [dpdk-dev] [PATCH v3] net/ixgbe: Add access and locking APIs for MDIO Thread-Index: AQHT0Z1lGf6GQY3YpUmB07CrH5+fhKP9+SSQ Date: Fri, 13 Apr 2018 02:37:54 +0000 Message-ID: <039ED4275CED7440929022BC67E70611531909EA@SHSMSX103.ccr.corp.intel.com> References: <20180321173618.74200-2-shweta.choudaha@gmail.com> <20180411135935.61232-1-shweta.choudaha@gmail.com> In-Reply-To: <20180411135935.61232-1-shweta.choudaha@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: Add access and locking APIs for MDIO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 02:38:37 -0000 Hi Choudaha: > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shweta Choudaha > Sent: Wednesday, April 11, 2018 10:00 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Zhang, Helin ; Yig= it, > Ferruh ; shweta.choudaha@att.com > Subject: [dpdk-dev] [PATCH v3] net/ixgbe: Add access and locking APIs for > MDIO Nitpick: title should not start with uppercase. > + > +EXPERIMENTAL { > + global: > + > + rte_pmd_ixgbe_lock_mdio; > + rte_pmd_ixgbe_unlock_mdio; Can we rename to rte_pmd_ixgbe_mdio_lock and rte_pmd_ixgbe_mdio_unlock, so = all mdio functions can be list closely when follow the alphabet sequence? > + rte_pmd_ixgbe_mdio_read_unlocked; > + rte_pmd_ixgbe_mdio_write_unlocked; And this could be rte_pmd_ixgbe_mdio_unlocked_read/write to follow the same= pattern that action after object Regards Qi > +} DPDK_18.05; > -- > 2.11.0