From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 0B75572FD for ; Wed, 18 Apr 2018 14:01:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2018 05:01:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,465,1517904000"; d="scan'208";a="35177898" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 18 Apr 2018 05:01:55 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 18 Apr 2018 05:01:53 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.210]) by shsmsx102.ccr.corp.intel.com ([169.254.2.79]) with mapi id 14.03.0319.002; Wed, 18 Apr 2018 20:01:51 +0800 From: "Zhang, Qi Z" To: "Xu, Rosen" , "dev@dpdk.org" CC: "Xing, Beilei" , "Zhang, Helin" , "Wu, Jingjing" Thread-Topic: [PATCH v4] drivers/net/i40e: fix missing promiscuous disable at device disable Thread-Index: AQHT1uyjJ3fgFA1a7kaukiOypAX0LqQGa+eg Date: Wed, 18 Apr 2018 12:01:51 +0000 Message-ID: <039ED4275CED7440929022BC67E706115319FBAB@SHSMSX103.ccr.corp.intel.com> References: <1521090873-50595-1-git-send-email-rosen.xu@intel.com> <1524039101-158658-1-git-send-email-rosen.xu@intel.com> In-Reply-To: <1524039101-158658-1-git-send-email-rosen.xu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTMzMjk1ZTMtMjExMC00M2I4LTlhNTItOThiMjgwMmQ2M2I3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJwQUtNQTBpYzBkdDNGTldBN1d2d0NLZ2o4aEc0cFlCQ1dMZE9HQUVOUkk3NkI5cEt3SnFKbDYzZFYrZGtYMGc1In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] drivers/net/i40e: fix missing promiscuous disable at device disable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 12:01:58 -0000 > -----Original Message----- > From: Xu, Rosen > Sent: Wednesday, April 18, 2018 4:12 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Helin > ; Zhang, Qi Z ; Wu, Jingjing > > Subject: [PATCH v4] drivers/net/i40e: fix missing promiscuous disable at > device disable >=20 > v4 updates: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > - Add some comments for this patch >=20 > v3 updates: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > - Move modification from device close to device disable > - i40evf_reset_vf() will cause kernel driver enable all vlan promiscuous= , > so unicast/multicast promiscuous disable should set before reset. >=20 > v2 updates: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > - Add more comments >=20 > In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit > doesn't disable promiscuous mode, this will cause vlan filter set by Kern= el > Driver will not take effect. >=20 > This patch will fix it, add promiscuous disable at device disable. >=20 > Signed-off-by: Rosen Xu Acked-by: Qi Zhang Change log need be removed when apply