* [dpdk-dev] [PATCH] net/i40e: fix I40e start failing for missing JUMBO_FRAME offload
@ 2018-04-17 7:28 Yanglong Wu
2018-04-17 10:38 ` Zhang, Qi Z
2018-04-18 1:42 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
0 siblings, 2 replies; 7+ messages in thread
From: Yanglong Wu @ 2018-04-17 7:28 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, wei.dai, lei.a.yao, Yanglong Wu
JUMBO_FRAME offload should be set as default,
missing it will lead to start failing for I40e.
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 180ac7449..c3bd254ae 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -3228,7 +3228,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
DEV_RX_OFFLOAD_CRC_STRIP |
DEV_RX_OFFLOAD_VLAN_EXTEND |
- DEV_RX_OFFLOAD_VLAN_FILTER;
+ DEV_RX_OFFLOAD_VLAN_FILTER |
+ DEV_RX_OFFLOAD_JUMBO_FRAME;
dev_info->tx_queue_offload_capa = 0;
dev_info->tx_offload_capa =
--
2.11.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix I40e start failing for missing JUMBO_FRAME offload
2018-04-17 7:28 [dpdk-dev] [PATCH] net/i40e: fix I40e start failing for missing JUMBO_FRAME offload Yanglong Wu
@ 2018-04-17 10:38 ` Zhang, Qi Z
2018-04-18 1:42 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
1 sibling, 0 replies; 7+ messages in thread
From: Zhang, Qi Z @ 2018-04-17 10:38 UTC (permalink / raw)
To: Wu, Yanglong, dev; +Cc: Dai, Wei, Yao, Lei A
> -----Original Message-----
> From: Wu, Yanglong
> Sent: Tuesday, April 17, 2018 3:29 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Dai, Wei <wei.dai@intel.com>; Yao,
> Lei A <lei.a.yao@intel.com>; Wu, Yanglong <yanglong.wu@intel.com>
> Subject: [PATCH] net/i40e: fix I40e start failing for missing JUMBO_FRAME
> offload
>
> JUMBO_FRAME offload should be set as default, missing it will lead to start
> failing for I40e.
>
Please add fixed commit here.
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 180ac7449..c3bd254ae 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -3228,7 +3228,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
> DEV_RX_OFFLOAD_CRC_STRIP |
> DEV_RX_OFFLOAD_VLAN_EXTEND |
> - DEV_RX_OFFLOAD_VLAN_FILTER;
> + DEV_RX_OFFLOAD_VLAN_FILTER |
> + DEV_RX_OFFLOAD_JUMBO_FRAME;
>
> dev_info->tx_queue_offload_capa = 0;
> dev_info->tx_offload_capa =
> --
> 2.11.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v2] net/i40e: fix I40e start failing for missing JUMBO_FRAME offload
2018-04-17 7:28 [dpdk-dev] [PATCH] net/i40e: fix I40e start failing for missing JUMBO_FRAME offload Yanglong Wu
2018-04-17 10:38 ` Zhang, Qi Z
@ 2018-04-18 1:42 ` Yanglong Wu
2018-04-18 12:16 ` Zhang, Qi Z
` (2 more replies)
1 sibling, 3 replies; 7+ messages in thread
From: Yanglong Wu @ 2018-04-18 1:42 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, wei.dai, lei.a.yao, Yanglong Wu
JUMBO_FRAME offload should be set as default,
missing it will lead to start failing for I40e.
Fixes: fbf959fe61e7 ("net/i40e: convert to new Rx offloads API")
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
v2:
add fix commit
---
drivers/net/i40e/i40e_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 180ac7449..c3bd254ae 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -3228,7 +3228,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
DEV_RX_OFFLOAD_CRC_STRIP |
DEV_RX_OFFLOAD_VLAN_EXTEND |
- DEV_RX_OFFLOAD_VLAN_FILTER;
+ DEV_RX_OFFLOAD_VLAN_FILTER |
+ DEV_RX_OFFLOAD_JUMBO_FRAME;
dev_info->tx_queue_offload_capa = 0;
dev_info->tx_offload_capa =
--
2.11.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/i40e: fix I40e start failing for missing JUMBO_FRAME offload
2018-04-18 1:42 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
@ 2018-04-18 12:16 ` Zhang, Qi Z
2018-04-19 2:10 ` [dpdk-dev] [PATCH] " Yanglong Wu
2018-04-19 2:19 ` [dpdk-dev] [PATCH v3] net/i40e:fix missing jumbo frame offload capability Yanglong Wu
2 siblings, 0 replies; 7+ messages in thread
From: Zhang, Qi Z @ 2018-04-18 12:16 UTC (permalink / raw)
To: Wu, Yanglong, dev; +Cc: Dai, Wei, Yao, Lei A
> -----Original Message-----
> From: Wu, Yanglong
> Sent: Wednesday, April 18, 2018 9:42 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Dai, Wei <wei.dai@intel.com>; Yao,
> Lei A <lei.a.yao@intel.com>; Wu, Yanglong <yanglong.wu@intel.com>
> Subject: [PATCH v2] net/i40e: fix I40e start failing for missing JUMBO_FRAME
> offload
>
> JUMBO_FRAME offload should be set as default, missing it will lead to start
> failing for I40e.
>
> Fixes: fbf959fe61e7 ("net/i40e: convert to new Rx offloads API")
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Title and commit log could be changed to
net/i40e: fix missing jumbo frame offload capability
JUMBO_FRAME offload capability should be exposed since i40e
does support it.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH] net/i40e: fix I40e start failing for missing JUMBO_FRAME offload
2018-04-18 1:42 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2018-04-18 12:16 ` Zhang, Qi Z
@ 2018-04-19 2:10 ` Yanglong Wu
2018-04-19 2:19 ` [dpdk-dev] [PATCH v3] net/i40e:fix missing jumbo frame offload capability Yanglong Wu
2 siblings, 0 replies; 7+ messages in thread
From: Yanglong Wu @ 2018-04-19 2:10 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, wei.dai, lei.a.yao, Yanglong Wu
JUMBO_FRAME offload should be set as default,
missing it will lead to start failing for I40e.
Fixes: fbf959fe61e7 ("net/i40e: convert to new Rx offloads API")
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
v2:
add fix commit
---
drivers/net/i40e/i40e_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 180ac7449..c3bd254ae 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -3228,7 +3228,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
DEV_RX_OFFLOAD_CRC_STRIP |
DEV_RX_OFFLOAD_VLAN_EXTEND |
- DEV_RX_OFFLOAD_VLAN_FILTER;
+ DEV_RX_OFFLOAD_VLAN_FILTER |
+ DEV_RX_OFFLOAD_JUMBO_FRAME;
dev_info->tx_queue_offload_capa = 0;
dev_info->tx_offload_capa =
--
2.11.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v3] net/i40e:fix missing jumbo frame offload capability
2018-04-18 1:42 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2018-04-18 12:16 ` Zhang, Qi Z
2018-04-19 2:10 ` [dpdk-dev] [PATCH] " Yanglong Wu
@ 2018-04-19 2:19 ` Yanglong Wu
2018-04-27 7:27 ` Zhang, Helin
2 siblings, 1 reply; 7+ messages in thread
From: Yanglong Wu @ 2018-04-19 2:19 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, wei.dai, lei.a.yao, Yanglong Wu
JUMBO_FRAME offload capability should
be exposed since i40e does support it.
Fixes: fbf959fe61e7 ("net/i40e: convert to new Rx offloads API")
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
---
v2:
add fix commit
---
v3:
rework commit log
---
drivers/net/i40e/i40e_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 180ac7449..c3bd254ae 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -3228,7 +3228,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
DEV_RX_OFFLOAD_CRC_STRIP |
DEV_RX_OFFLOAD_VLAN_EXTEND |
- DEV_RX_OFFLOAD_VLAN_FILTER;
+ DEV_RX_OFFLOAD_VLAN_FILTER |
+ DEV_RX_OFFLOAD_JUMBO_FRAME;
dev_info->tx_queue_offload_capa = 0;
dev_info->tx_offload_capa =
--
2.11.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v3] net/i40e:fix missing jumbo frame offload capability
2018-04-19 2:19 ` [dpdk-dev] [PATCH v3] net/i40e:fix missing jumbo frame offload capability Yanglong Wu
@ 2018-04-27 7:27 ` Zhang, Helin
0 siblings, 0 replies; 7+ messages in thread
From: Zhang, Helin @ 2018-04-27 7:27 UTC (permalink / raw)
To: Wu, Yanglong, dev; +Cc: Zhang, Qi Z, Dai, Wei, Yao, Lei A, Wu, Yanglong
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu
> Sent: Thursday, April 19, 2018 10:19 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z; Dai, Wei; Yao, Lei A; Wu, Yanglong
> Subject: [dpdk-dev] [PATCH v3] net/i40e:fix missing jumbo frame offload
> capability
>
> JUMBO_FRAME offload capability should
> be exposed since i40e does support it.
>
> Fixes: fbf959fe61e7 ("net/i40e: convert to new Rx offloads API")
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!
/Helin
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-04-27 7:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-17 7:28 [dpdk-dev] [PATCH] net/i40e: fix I40e start failing for missing JUMBO_FRAME offload Yanglong Wu
2018-04-17 10:38 ` Zhang, Qi Z
2018-04-18 1:42 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2018-04-18 12:16 ` Zhang, Qi Z
2018-04-19 2:10 ` [dpdk-dev] [PATCH] " Yanglong Wu
2018-04-19 2:19 ` [dpdk-dev] [PATCH v3] net/i40e:fix missing jumbo frame offload capability Yanglong Wu
2018-04-27 7:27 ` Zhang, Helin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).