From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: fix queue offload initialize
Date: Thu, 3 May 2018 00:54:16 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611531AB716@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258AEDC160F@irsmsx105.ger.corp.intel.com>
> -----Original Message-----
> From: Ananyev, Konstantin
> Sent: Wednesday, May 2, 2018 7:29 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>
> Subject: RE: [PATCH v2 1/2] net/i40e: fix queue offload initialize
>
>
>
> > -----Original Message-----
> > From: Zhang, Qi Z
> > Sent: Wednesday, May 2, 2018 4:57 AM
> > To: Yigit, Ferruh <ferruh.yigit@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>
> > Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>
> > Subject: [PATCH v2 1/2] net/i40e: fix queue offload initialize
> >
> > Add missing queue offload initialization.
> >
> > Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
> > Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> >
> > v2:
> > - add missing part in i40e_vf_represent.
> >
> > drivers/net/i40e/i40e_ethdev.c | 1 +
> > drivers/net/i40e/i40e_ethdev_vf.c | 1 +
> > drivers/net/i40e/i40e_rxtx.c | 2 ++
> > drivers/net/i40e/i40e_vf_representor.c | 2 ++
> > 4 files changed, 6 insertions(+)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index 284e9cb64..a001d5b99 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -3345,6 +3345,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *dev_info)
> > .tx_rs_thresh = I40E_DEFAULT_TX_RSBIT_THRESH,
> > .txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |
> > ETH_TXQ_FLAGS_NOOFFLOADS,
> > + .offloads = 0,
> > };
> >
> > dev_info->rx_desc_lim = (struct rte_eth_desc_lim) { diff --git
> > a/drivers/net/i40e/i40e_ethdev_vf.c
> > b/drivers/net/i40e/i40e_ethdev_vf.c
> > index 48e7ac21e..de5f460e9 100644
> > --- a/drivers/net/i40e/i40e_ethdev_vf.c
> > +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> > @@ -2238,6 +2238,7 @@ i40evf_dev_info_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *dev_info)
> > .tx_rs_thresh = I40E_DEFAULT_TX_RSBIT_THRESH,
> > .txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |
> > ETH_TXQ_FLAGS_NOOFFLOADS,
> > + .offloads = 0,
> > };
> >
> > dev_info->rx_desc_lim = (struct rte_eth_desc_lim) { diff --git
> > a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index
> > 006f5b846..755109ee5 100644
> > --- a/drivers/net/i40e/i40e_rxtx.c
> > +++ b/drivers/net/i40e/i40e_rxtx.c
> > @@ -1857,6 +1857,7 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev
> *dev,
> > rxq->drop_en = rx_conf->rx_drop_en;
> > rxq->vsi = vsi;
> > rxq->rx_deferred_start = rx_conf->rx_deferred_start;
> > + rxq->offloads = rx_conf->offloads;
> >
> > /* Allocate the maximun number of RX ring hardware descriptor. */
> > len = I40E_MAX_RING_DESC;
> > @@ -2297,6 +2298,7 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev
> *dev,
> > txq->reg_idx = reg_idx;
> > txq->port_id = dev->data->port_id;
> > txq->txq_flags = tx_conf->txq_flags;
> > + txq->offloads = tx_conf->offloads;
> > txq->vsi = vsi;
> > txq->tx_deferred_start = tx_conf->tx_deferred_start;
> >
>
> Looks ok, but I think you forgot to:
> qinfo->conf.offloads = txq->offloads;
> inside i40e_txq_info_get()
> Konstantin
Yes, will add this.
>
> > diff --git a/drivers/net/i40e/i40e_vf_representor.c
> > b/drivers/net/i40e/i40e_vf_representor.c
> > index a8aa0115d..95c6696b8 100644
> > --- a/drivers/net/i40e/i40e_vf_representor.c
> > +++ b/drivers/net/i40e/i40e_vf_representor.c
> > @@ -69,6 +69,7 @@ i40e_vf_representor_dev_infos_get(struct
> rte_eth_dev *ethdev,
> > },
> > .rx_free_thresh = I40E_DEFAULT_RX_FREE_THRESH,
> > .rx_drop_en = 0,
> > + .offloads = 0,
> > };
> >
> > dev_info->default_txconf = (struct rte_eth_txconf) { @@ -81,6 +82,7
> > @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev,
> > .tx_rs_thresh = I40E_DEFAULT_TX_RSBIT_THRESH,
> > .txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |
> > ETH_TXQ_FLAGS_NOOFFLOADS,
> > + .offloads = 0,
> > };
> >
> > dev_info->rx_desc_lim = (struct rte_eth_desc_lim) {
> > --
> > 2.13.6
prev parent reply other threads:[~2018-05-03 0:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 3:56 Qi Zhang
2018-05-02 3:56 ` [dpdk-dev] [PATCH v2 2/2] net/i40e: remove dependence on Tx queue flags Qi Zhang
2018-05-02 10:54 ` [dpdk-dev] [PATCH v2 1/2] net/i40e: fix queue offload initialize Ferruh Yigit
2018-05-02 11:28 ` Ananyev, Konstantin
2018-05-03 0:54 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611531AB716@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).