From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2EFFB231E for ; Thu, 3 May 2018 02:54:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2018 17:54:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,356,1520924400"; d="scan'208";a="225320542" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 02 May 2018 17:54:19 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 2 May 2018 17:54:19 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 2 May 2018 17:54:18 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.210]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.179]) with mapi id 14.03.0319.002; Thu, 3 May 2018 08:54:17 +0800 From: "Zhang, Qi Z" To: "Ananyev, Konstantin" , "Yigit, Ferruh" CC: "dev@dpdk.org" , "Xing, Beilei" Thread-Topic: [PATCH v2 1/2] net/i40e: fix queue offload initialize Thread-Index: AQHT4cmOCiO8c6Vz/02IP9D25xE5nKQbx8uAgAFnDIA= Date: Thu, 3 May 2018 00:54:16 +0000 Message-ID: <039ED4275CED7440929022BC67E70611531AB716@SHSMSX103.ccr.corp.intel.com> References: <20180502035633.130415-1-qi.z.zhang@intel.com> <2601191342CEEE43887BDE71AB977258AEDC160F@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258AEDC160F@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2YxM2Q2ODMtMmM3Yi00Y2EyLWI5MDAtZWE2OGY4MmNjMWYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJxSmFuK1V3SnUrNVN3bmRXcmptdExSNUlQK1Y0bHdtZWhkZXF5VTZ6bjE3OGZIN1NaRUZtTXY2ZW9zQVVRWnFZIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: fix queue offload initialize X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2018 00:54:20 -0000 > -----Original Message----- > From: Ananyev, Konstantin > Sent: Wednesday, May 2, 2018 7:29 PM > To: Zhang, Qi Z ; Yigit, Ferruh > Cc: dev@dpdk.org; Xing, Beilei > Subject: RE: [PATCH v2 1/2] net/i40e: fix queue offload initialize >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Wednesday, May 2, 2018 4:57 AM > > To: Yigit, Ferruh ; Ananyev, Konstantin > > > > Cc: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > > > > Subject: [PATCH v2 1/2] net/i40e: fix queue offload initialize > > > > Add missing queue offload initialization. > > > > Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") > > Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API") > > > > Signed-off-by: Qi Zhang > > --- > > > > v2: > > - add missing part in i40e_vf_represent. > > > > drivers/net/i40e/i40e_ethdev.c | 1 + > > drivers/net/i40e/i40e_ethdev_vf.c | 1 + > > drivers/net/i40e/i40e_rxtx.c | 2 ++ > > drivers/net/i40e/i40e_vf_representor.c | 2 ++ > > 4 files changed, 6 insertions(+) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index 284e9cb64..a001d5b99 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -3345,6 +3345,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev, > struct rte_eth_dev_info *dev_info) > > .tx_rs_thresh =3D I40E_DEFAULT_TX_RSBIT_THRESH, > > .txq_flags =3D ETH_TXQ_FLAGS_NOMULTSEGS | > > ETH_TXQ_FLAGS_NOOFFLOADS, > > + .offloads =3D 0, > > }; > > > > dev_info->rx_desc_lim =3D (struct rte_eth_desc_lim) { diff --git > > a/drivers/net/i40e/i40e_ethdev_vf.c > > b/drivers/net/i40e/i40e_ethdev_vf.c > > index 48e7ac21e..de5f460e9 100644 > > --- a/drivers/net/i40e/i40e_ethdev_vf.c > > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > > @@ -2238,6 +2238,7 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, > struct rte_eth_dev_info *dev_info) > > .tx_rs_thresh =3D I40E_DEFAULT_TX_RSBIT_THRESH, > > .txq_flags =3D ETH_TXQ_FLAGS_NOMULTSEGS | > > ETH_TXQ_FLAGS_NOOFFLOADS, > > + .offloads =3D 0, > > }; > > > > dev_info->rx_desc_lim =3D (struct rte_eth_desc_lim) { diff --git > > a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index > > 006f5b846..755109ee5 100644 > > --- a/drivers/net/i40e/i40e_rxtx.c > > +++ b/drivers/net/i40e/i40e_rxtx.c > > @@ -1857,6 +1857,7 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev > *dev, > > rxq->drop_en =3D rx_conf->rx_drop_en; > > rxq->vsi =3D vsi; > > rxq->rx_deferred_start =3D rx_conf->rx_deferred_start; > > + rxq->offloads =3D rx_conf->offloads; > > > > /* Allocate the maximun number of RX ring hardware descriptor. */ > > len =3D I40E_MAX_RING_DESC; > > @@ -2297,6 +2298,7 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev > *dev, > > txq->reg_idx =3D reg_idx; > > txq->port_id =3D dev->data->port_id; > > txq->txq_flags =3D tx_conf->txq_flags; > > + txq->offloads =3D tx_conf->offloads; > > txq->vsi =3D vsi; > > txq->tx_deferred_start =3D tx_conf->tx_deferred_start; > > >=20 > Looks ok, but I think you forgot to: > qinfo->conf.offloads =3D txq->offloads; > inside i40e_txq_info_get() > Konstantin Yes, will add this. >=20 > > diff --git a/drivers/net/i40e/i40e_vf_representor.c > > b/drivers/net/i40e/i40e_vf_representor.c > > index a8aa0115d..95c6696b8 100644 > > --- a/drivers/net/i40e/i40e_vf_representor.c > > +++ b/drivers/net/i40e/i40e_vf_representor.c > > @@ -69,6 +69,7 @@ i40e_vf_representor_dev_infos_get(struct > rte_eth_dev *ethdev, > > }, > > .rx_free_thresh =3D I40E_DEFAULT_RX_FREE_THRESH, > > .rx_drop_en =3D 0, > > + .offloads =3D 0, > > }; > > > > dev_info->default_txconf =3D (struct rte_eth_txconf) { @@ -81,6 +82,7 > > @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev, > > .tx_rs_thresh =3D I40E_DEFAULT_TX_RSBIT_THRESH, > > .txq_flags =3D ETH_TXQ_FLAGS_NOMULTSEGS | > > ETH_TXQ_FLAGS_NOOFFLOADS, > > + .offloads =3D 0, > > }; > > > > dev_info->rx_desc_lim =3D (struct rte_eth_desc_lim) { > > -- > > 2.13.6