From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wu, Yanglong" <yanglong.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Dai, Wei" <wei.dai@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix missing VLAN offload capability
Date: Thu, 10 May 2018 03:06:16 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611531B063A@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20180510024513.75072-1-yanglong.wu@intel.com>
> -----Original Message-----
> From: Wu, Yanglong
> Sent: Thursday, May 10, 2018 10:45 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Dai, Wei <wei.dai@intel.com>; Wu,
> Yanglong <yanglong.wu@intel.com>
> Subject: [PATCH] net/i40e: fix missing VLAN offload capability
>
> VLAN offload capability should be exposed both VF and PF since i40e does
> support it.
>
> Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 894505f98..ad377f440 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -3299,7 +3299,9 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> DEV_RX_OFFLOAD_CRC_STRIP |
> DEV_RX_OFFLOAD_VLAN_EXTEND |
> DEV_RX_OFFLOAD_VLAN_FILTER |
> - DEV_RX_OFFLOAD_JUMBO_FRAME;
> + DEV_RX_OFFLOAD_JUMBO_FRAME |
> + DEV_RX_OFFLOAD_VLAN_FILTER |
> + DEV_RX_OFFLOAD_VLAN_EXTEND;
This is duplicate.
I guess want to add missing flags to i40evf_dev_info_get ?
>
> dev_info->tx_queue_offload_capa =
> DEV_TX_OFFLOAD_MBUF_FAST_FREE;
> dev_info->tx_offload_capa =
> --
> 2.11.0
next prev parent reply other threads:[~2018-05-10 3:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 2:45 Yanglong Wu
2018-05-10 3:06 ` Zhang, Qi Z [this message]
2018-05-10 4:57 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2018-05-10 6:50 ` Yanglong Wu
2018-05-11 1:35 ` Zhang, Qi Z
2018-05-11 1:53 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611531B063A@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=wei.dai@intel.com \
--cc=yanglong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).