* [dpdk-dev] [PATCH] net/i40e: fix missing VLAN offload capability
@ 2018-05-10 2:45 Yanglong Wu
2018-05-10 3:06 ` Zhang, Qi Z
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Yanglong Wu @ 2018-05-10 2:45 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, wei.dai, Yanglong Wu
VLAN offload capability should be exposed both
VF and PF since i40e does support it.
Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 894505f98..ad377f440 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -3299,7 +3299,9 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
DEV_RX_OFFLOAD_CRC_STRIP |
DEV_RX_OFFLOAD_VLAN_EXTEND |
DEV_RX_OFFLOAD_VLAN_FILTER |
- DEV_RX_OFFLOAD_JUMBO_FRAME;
+ DEV_RX_OFFLOAD_JUMBO_FRAME |
+ DEV_RX_OFFLOAD_VLAN_FILTER |
+ DEV_RX_OFFLOAD_VLAN_EXTEND;
dev_info->tx_queue_offload_capa = DEV_TX_OFFLOAD_MBUF_FAST_FREE;
dev_info->tx_offload_capa =
--
2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix missing VLAN offload capability
2018-05-10 2:45 [dpdk-dev] [PATCH] net/i40e: fix missing VLAN offload capability Yanglong Wu
@ 2018-05-10 3:06 ` Zhang, Qi Z
2018-05-10 4:57 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2018-05-10 6:50 ` Yanglong Wu
2 siblings, 0 replies; 6+ messages in thread
From: Zhang, Qi Z @ 2018-05-10 3:06 UTC (permalink / raw)
To: Wu, Yanglong, dev; +Cc: Dai, Wei
> -----Original Message-----
> From: Wu, Yanglong
> Sent: Thursday, May 10, 2018 10:45 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Dai, Wei <wei.dai@intel.com>; Wu,
> Yanglong <yanglong.wu@intel.com>
> Subject: [PATCH] net/i40e: fix missing VLAN offload capability
>
> VLAN offload capability should be exposed both VF and PF since i40e does
> support it.
>
> Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 894505f98..ad377f440 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -3299,7 +3299,9 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> DEV_RX_OFFLOAD_CRC_STRIP |
> DEV_RX_OFFLOAD_VLAN_EXTEND |
> DEV_RX_OFFLOAD_VLAN_FILTER |
> - DEV_RX_OFFLOAD_JUMBO_FRAME;
> + DEV_RX_OFFLOAD_JUMBO_FRAME |
> + DEV_RX_OFFLOAD_VLAN_FILTER |
> + DEV_RX_OFFLOAD_VLAN_EXTEND;
This is duplicate.
I guess want to add missing flags to i40evf_dev_info_get ?
>
> dev_info->tx_queue_offload_capa =
> DEV_TX_OFFLOAD_MBUF_FAST_FREE;
> dev_info->tx_offload_capa =
> --
> 2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] net/i40e: fix missing VLAN offload capability
2018-05-10 2:45 [dpdk-dev] [PATCH] net/i40e: fix missing VLAN offload capability Yanglong Wu
2018-05-10 3:06 ` Zhang, Qi Z
@ 2018-05-10 4:57 ` Yanglong Wu
2018-05-10 6:50 ` Yanglong Wu
2 siblings, 0 replies; 6+ messages in thread
From: Yanglong Wu @ 2018-05-10 4:57 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, wei.dai, Yanglong Wu
VLAN offload capability should be exposed in VF
since i40e does support it.
Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
v2:
rework as comments required
---
drivers/net/i40e/i40e_ethdev_vf.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index b9dea2e5b..33beded37 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2200,7 +2200,9 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
DEV_RX_OFFLOAD_TCP_CKSUM |
DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
DEV_RX_OFFLOAD_CRC_STRIP |
- DEV_RX_OFFLOAD_SCATTER;
+ DEV_RX_OFFLOAD_SCATTER |
+ DEV_RX_OFFLOAD_VLAN_FILTER |
+ DEV_RX_OFFLOAD_VLAN_EXTEND;
dev_info->tx_queue_offload_capa = 0;
dev_info->tx_offload_capa =
--
2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] net/i40e: fix missing VLAN offload capability
2018-05-10 2:45 [dpdk-dev] [PATCH] net/i40e: fix missing VLAN offload capability Yanglong Wu
2018-05-10 3:06 ` Zhang, Qi Z
2018-05-10 4:57 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
@ 2018-05-10 6:50 ` Yanglong Wu
2018-05-11 1:35 ` Zhang, Qi Z
2 siblings, 1 reply; 6+ messages in thread
From: Yanglong Wu @ 2018-05-10 6:50 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, wei.dai, Yanglong Wu
VLAN offload capability should be exposed in VF
since i40e does support it.
Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
v2:
rework as comments required
---
drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index b9dea2e5b..2a37b31b2 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2200,7 +2200,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
DEV_RX_OFFLOAD_TCP_CKSUM |
DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
DEV_RX_OFFLOAD_CRC_STRIP |
- DEV_RX_OFFLOAD_SCATTER;
+ DEV_RX_OFFLOAD_SCATTER |
+ DEV_RX_OFFLOAD_VLAN_FILTER;
dev_info->tx_queue_offload_capa = 0;
dev_info->tx_offload_capa =
--
2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/i40e: fix missing VLAN offload capability
2018-05-10 6:50 ` Yanglong Wu
@ 2018-05-11 1:35 ` Zhang, Qi Z
2018-05-11 1:53 ` Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Zhang, Qi Z @ 2018-05-11 1:35 UTC (permalink / raw)
To: Wu, Yanglong, dev; +Cc: Dai, Wei
Hi Yanglong
The patch is OK, could you rebase to dpdk-next-net ?
Thanks
Qi
> -----Original Message-----
> From: Wu, Yanglong
> Sent: Thursday, May 10, 2018 2:51 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Dai, Wei <wei.dai@intel.com>; Wu,
> Yanglong <yanglong.wu@intel.com>
> Subject: [PATCH v2] net/i40e: fix missing VLAN offload capability
>
> VLAN offload capability should be exposed in VF since i40e does support it.
>
> Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
> v2:
> rework as comments required
> ---
> drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index b9dea2e5b..2a37b31b2 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -2200,7 +2200,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> DEV_RX_OFFLOAD_TCP_CKSUM |
> DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
> DEV_RX_OFFLOAD_CRC_STRIP |
> - DEV_RX_OFFLOAD_SCATTER;
> + DEV_RX_OFFLOAD_SCATTER |
> + DEV_RX_OFFLOAD_VLAN_FILTER;
>
> dev_info->tx_queue_offload_capa = 0;
> dev_info->tx_offload_capa =
> --
> 2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/i40e: fix missing VLAN offload capability
2018-05-11 1:35 ` Zhang, Qi Z
@ 2018-05-11 1:53 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2018-05-11 1:53 UTC (permalink / raw)
To: Zhang, Qi Z, Wu, Yanglong, dev; +Cc: Dai, Wei
On 5/11/2018 2:35 AM, Zhang, Qi Z wrote:
> Hi Yanglong
> The patch is OK, could you rebase to dpdk-next-net ?
> Thanks
> Qi
>
>> -----Original Message-----
>> From: Wu, Yanglong
>> Sent: Thursday, May 10, 2018 2:51 PM
>> To: dev@dpdk.org
>> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Dai, Wei <wei.dai@intel.com>; Wu,
>> Yanglong <yanglong.wu@intel.com>
>> Subject: [PATCH v2] net/i40e: fix missing VLAN offload capability
>>
>> VLAN offload capability should be exposed in VF since i40e does support it.
>>
>> Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
>> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-11 1:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-10 2:45 [dpdk-dev] [PATCH] net/i40e: fix missing VLAN offload capability Yanglong Wu
2018-05-10 3:06 ` Zhang, Qi Z
2018-05-10 4:57 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2018-05-10 6:50 ` Yanglong Wu
2018-05-11 1:35 ` Zhang, Qi Z
2018-05-11 1:53 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).