From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <qi.z.zhang@intel.com> Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 5E8C044BE for <dev@dpdk.org>; Tue, 26 Jun 2018 09:03:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2018 00:03:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,273,1526367600"; d="scan'208";a="67754908" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 26 Jun 2018 00:03:03 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 26 Jun 2018 00:03:03 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 26 Jun 2018 00:03:03 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.70]) with mapi id 14.03.0319.002; Tue, 26 Jun 2018 15:03:01 +0800 From: "Zhang, Qi Z" <qi.z.zhang@intel.com> To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net>, "Richardson, Bruce" <bruce.richardson@intel.com> Thread-Topic: [dpdk-dev] [PATCH 0/8] Remove IPC threads Thread-Index: AQHUBLS2PKFie3txNkSRAR62oKRw56RxvtGAgABtkUA= Date: Tue, 26 Jun 2018 07:03:01 +0000 Message-ID: <039ED4275CED7440929022BC67E706115323E2E4@SHSMSX103.ccr.corp.intel.com> References: <cover.1529071026.git.anatoly.burakov@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzhiN2VlZWUtYmVhZS00NmJiLTgzMmYtMzlkMzk5NGU1ZDg5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZHVRRXMzUnNcL3B0WTdJTEFXNVJ1OUtTM09UdFVmQmZWQVQ3YmczY1lMZmdwQ1dQUGN5KzhJSFhrRlNKekNBd3YifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/8] Remove IPC threads X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 26 Jun 2018 07:03:13 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Tuesday, June 26, 2018 9:19 AM > To: 'Anatoly Burakov' <anatoly.burakov@intel.com>; dev@dpdk.org > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; > thomas@monjalon.net; Richardson, Bruce <bruce.richardson@intel.com> > Subject: RE: [dpdk-dev] [PATCH 0/8] Remove IPC threads >=20 > Hi Anatoly and Thomas: >=20 > Sorry for raise this late, but seems merge mp thread into interrupt threa= d gives > problem to enable hotplug on secondary [1]. >=20 > The issue is, when secondary want to attach a share device, it send reque= st to > primary Then primary is running in mp callback (mp thread) to attach devi= ce, it > will call rte_malloc which get chance to increase heap that will do sync = IPC, You > know, this is the limitation we can't do sync IPC in mp thread itself. so= the > solution is try to move real work to a separate thread which has no limit= ation > to do sync IPC, and interrupt thread is the good candidate, because we ju= st > need to call rte_eal_set_alarm and we don't need to worry about the > execution sequence. >=20 > But if we merge mp thread into interrupt thread, the solution will not wo= rk, we > may need to create specific temporal thread to handle callback, but this = looks > like some re-build which we already have. Ok, actually this method looks good to me :), I will send v4 to have this, But please let me know if you have better idea. > So I think we need to revisit if we need to merge the thread before we ha= ve a > good solution for such kind of issue. >=20 > Thanks > Qi >=20 > [1] https://mails.dpdk.org/archives/dev/2018-June/105018.html >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anatoly Burakov > > Sent: Friday, June 15, 2018 10:25 PM > > To: dev@dpdk.org > > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; > > thomas@monjalon.net; Richardson, Bruce <bruce.richardson@intel.com> > > Subject: [dpdk-dev] [PATCH 0/8] Remove IPC threads > > > > As previously discussed [1], IPC threads need to be removed and their > > workload moved to interrupt thread. > > > > FreeBSD did not have an interrupt thread, nor did it support alarm > > API. This patchset adds support for both on FreeBSD. FreeBSD interrupt > > thread is based on kevent, FreeBSD's native event multiplexing > > mechanism similar to Linux's epoll. > > > > The patchset makes FreeBSD's interrupts and alarm work just enough to > > suffice for purposes of IPC, however there are really weird problems > observed. > > Specifically, FreeBSD's kevent timers are really slow to trigger for > > some reason, sleeping on a 10ms timer as much as 200ms before waking > > up. Interrupt handling on fd's is also a bit flaky. > > > > It has also been observed that both problems go away if we do not > > affinitize master lcore (by commenting relevant code out [2]). It is > > not known why these problems are observed, nor it is clear what a solut= ion > might entail. > > > > For the purposes of making IPC work and having rudimentary support for > > alarm and interrupt API's, this patchset works fine. However, because > > of the above described issues, documentation will not be updated to > > indicate support for interrupts on FreeBSD at this time. > > > > [1] http://dpdk.org/dev/patchwork/patch/36579/ > > [2] > > http://dpdk.org/browse/dpdk/tree/lib/librte_eal/bsdapp/eal/eal.c#n729 > > > > Anatoly Burakov (4): > > ipc: remove IPC thread for async requests > > eal/bsdapp: add interrupt thread > > eal/bsdapp: add alarm support > > ipc: remove main IPC thread > > > > Jianfeng Tan (4): > > eal/linux: use glibc malloc in alarm > > eal/linux: use glibc malloc in interrupt handling > > eal: bring forward init of interrupt handling > > eal: add IPC type for interrupt thread > > > > lib/librte_eal/bsdapp/eal/eal.c | 10 +- > > lib/librte_eal/bsdapp/eal/eal_alarm.c | 299 +++++++++++- > > lib/librte_eal/bsdapp/eal/eal_alarm_private.h | 19 + > > lib/librte_eal/bsdapp/eal/eal_interrupts.c | 460 +++++++++++++++++- > > lib/librte_eal/common/eal_common_proc.c | 243 ++++----- > > .../common/include/rte_eal_interrupts.h | 1 + > > lib/librte_eal/linuxapp/eal/eal.c | 10 +- > > lib/librte_eal/linuxapp/eal/eal_alarm.c | 9 +- > > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 19 +- > > test/test/test_interrupts.c | 29 +- > > 10 files changed, 899 insertions(+), 200 deletions(-) create mode > > 100644 lib/librte_eal/bsdapp/eal/eal_alarm_private.h > > > > -- > > 2.17.1