From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix link speed issue
Date: Tue, 10 Jul 2018 11:58:16 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153257E9F@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1531215055-14795-2-git-send-email-xiaoyun.li@intel.com>
> -----Original Message-----
> From: Li, Xiaoyun
> Sent: Tuesday, July 10, 2018 5:31 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/i40e: fix link speed issue
>
> When link needs to go up, I40E_AQ_PHY_AN_ENABLED is always be set in
> DPDK.
> So all speeds are always set. This causes speed config never works.
>
> This patch fixes this issue and only allows to set available speeds. If link needs
> to go up and speed setting is not supported, it will print warning and set
> default available speeds. And when link needs to go down, link speed field
> should be set to non-zero to avoid link down issue when binding back to kernel
> driver.
>
> Fixes: ca7e599d4506 ("net/i40e: fix link management")
> Fixes: 1bb8f661168d ("net/i40e: fix link down and negotiation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks!
Qi
prev parent reply other threads:[~2018-07-10 11:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 5:18 [dpdk-dev] [PATCH] " Xiaoyun Li
2018-07-10 7:57 ` Zhang, Qi Z
2018-07-10 9:30 ` [dpdk-dev] [PATCH v2] " Xiaoyun Li
2018-07-10 9:30 ` Xiaoyun Li
2018-07-10 11:58 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E7061153257E9F@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).