Re: [dpdk-dev] [PATCH v2] net/i40e: fix avx2 driver check for rx rearm

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Coyle, David
> Sent: Tuesday, July 31, 2018 10:25 PM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>; dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; stable@dpdk.org;
> thomas@monjalon.net; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: RE: [PATCH v2] net/i40e: fix avx2 driver check for rx rearm
> 
> 
> 
> -----Original Message-----
> From: Van Haaren, Harry
> Sent: Monday, July 30, 2018 6:34 PM
> To: dev@dpdk.org
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; stable@dpdk.org; thomas@monjalon.net;
> Coyle, David <david.coyle@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH v2] net/i40e: fix avx2 driver check for rx rearm
> 
> This commit fixes an infinite loop bug that could occur if the i40e AVX2 driver
> is used, and high traffic rates cause the mempool from which the rxq pulls
> mbufs to become empty.
> 
> The result would be an infinite loop of checking if we should perform an rx
> rearm, calling the function and an error return due the the mempool being
> emtpy.
> 
> The fix is to align the code in the AVX2 driver with the SSE driver, where an if()
> is used instead of a while(), allowing the thread to return from i40e rx
> function even if the mempool is empty.
> 
> Fixes: dafadd73762e ("net/i40e: add AVX2 Rx function")
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
> 
> Reported-by: David Coyle <david.coyle@intel.com>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> Acked-by: Brendan Ryan <brendan.ryan@intel.com>
> Tested-by: David Coyle <david.coyle@intel.com>

Applied to dpdk-next-net-intel.

Thanks!
Qi