From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Wang, Xiao W" <xiao.w.wang@intel.com>
Cc: "Bie, Tiwei" <tiwei.bie@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready
Date: Tue, 18 Sep 2018 14:20:41 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153287C6C@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20180914084132.GA23570@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ye Xiaolong
> Sent: Friday, September 14, 2018 4:42 PM
> To: Wang, Xiao W <xiao.w.wang@intel.com>
> Cc: Bie, Tiwei <tiwei.bie@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready
>
> Looks good to me.
>
> Reviewed-by: Ye Xiaolong <xiaolong.ye@intel.com>
>
> Thanks,
> Xiaolong
>
> On 09/14, Xiao Wang wrote:
> >If the device is not clearly reset by the previous driver and holds
> >some invalid ring addr, and the relay thread kicks it before HW is
> >properly re-configured, a bad DMA request may happen.
> >
> >Besides, the notify_addr which is used by the relay thread is set in
> >the vdpa_ifcvf_start function, if a kick relay happens before
> >vdpa_ifcvf_start finishes, a null addr is accessed.
> >
> >Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
> >
> >Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
next prev parent reply other threads:[~2018-09-18 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 11:05 [dpdk-dev] [PATCH] " Xiao Wang
2018-09-13 12:55 ` Ye Xiaolong
2018-09-13 7:23 ` Wang, Xiao W
2018-09-13 20:25 ` Ye Xiaolong
2018-09-14 1:25 ` [dpdk-dev] [PATCH v2] " Xiao Wang
2018-09-14 8:41 ` Ye Xiaolong
2018-09-18 14:20 ` Zhang, Qi Z [this message]
2018-09-25 17:15 ` Kevin Traynor
2018-09-26 0:12 ` Wang, Xiao W
2018-09-26 7:53 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E7061153287C6C@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).